pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: pkgsrc/devel/gnustep-objc



Module Name:    pkgsrc
Committed By:   pho
Date:           Wed Aug 23 11:57:05 UTC 2023

Modified Files:
        pkgsrc/devel/gnustep-objc: Makefile

Log Message:
devel/gnustep-objc: Fix unusable libobjc being produced when PKGSRC_MKPIE is set to yes (default)

Do not override CMAKE_C_COMPILER or CMAKE_CXX_COMPILER. Doing so causes
cmake to ignore cwrappers and try compiling test executables without -fPIC,
which fails, and the resulting libobjc.so will not contain any symbols from
${WRKSRC}/objcxx_eh.cc even though it still has (undefined) references to
them, e.g. test_eh_personality. devel/gnustep-base, or anything requiring
libobjc.so, will choke on missing symbols and fail to link.


To generate a diff of this commit:
cvs rdiff -u -r1.38 -r1.39 pkgsrc/devel/gnustep-objc/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/devel/gnustep-objc/Makefile
diff -u pkgsrc/devel/gnustep-objc/Makefile:1.38 pkgsrc/devel/gnustep-objc/Makefile:1.39
--- pkgsrc/devel/gnustep-objc/Makefile:1.38     Tue Jun  6 12:40:37 2023
+++ pkgsrc/devel/gnustep-objc/Makefile  Wed Aug 23 11:57:05 2023
@@ -1,7 +1,8 @@
-# $NetBSD: Makefile,v 1.38 2023/06/06 12:40:37 riastradh Exp $
+# $NetBSD: Makefile,v 1.39 2023/08/23 11:57:05 pho Exp $
 
 DISTNAME=      libobjc2-2.1.0
 PKGNAME=       ${DISTNAME:S/libobjc2/gnustep-objc/}
+PKGREVISION=   1
 CATEGORIES=    devel gnustep
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=gnustep/}
 GITHUB_PROJECT=        libobjc2
@@ -17,8 +18,6 @@ TOOL_DEPENDS+=        clang-[0-9]*:../../lang/c
 USE_LANGUAGES=                 objc c++11
 USE_TOOLS+=                    gmake cmake pax
 USE_CMAKE=                     yes
-CMAKE_ARGS+=                   -DCMAKE_C_COMPILER=${CLANGBASE:Q}/bin/clang
-CMAKE_ARGS+=                   -DCMAKE_CXX_COMPILER=${CLANGBASE:Q}/bin/clang++
 LDFLAGS+=                      -lm -lunwind -lstdc++
 MAKE_FILE=                     Makefile
 MAKE_ENV+=                     ADDITIONAL_LDFLAGS="-lpthread"



Home | Main Index | Thread Index | Old Index