Re: CVS commit: pkgsrc/cad

[nia <nia%NetBSD.org@localhost>]

On Tue, Jul 18, 2023 at 09:08:32PM +0200, Manuel Bouyer wrote:
> On Tue, Jul 18, 2023 at 07:04:00PM +0000, nia wrote:
> > On Tue, Jul 18, 2023 at 03:58:10PM +0200, Manuel Bouyer wrote:
> > > Hello,
> > > 
> > > 
> > > On Tue, Jul 18, 2023 at 12:58:53PM +0000, Nia Alarie wrote:
> > > > [...]
> > > > Index: pkgsrc/cad/kicad/Makefile
> > > > diff -u pkgsrc/cad/kicad/Makefile:1.79 pkgsrc/cad/kicad/Makefile:1.80
> > > > --- pkgsrc/cad/kicad/Makefile:1.79      Tue Jun  6 12:40:19 2023
> > > > +++ pkgsrc/cad/kicad/Makefile   Tue Jul 18 12:58:53 2023
> > > > @@ -1,4 +1,4 @@
> > > > -# $NetBSD: Makefile,v 1.79 2023/06/06 12:40:19 riastradh Exp $
> > > > +# $NetBSD: Makefile,v 1.80 2023/07/18 12:58:53 nia Exp $
> > > >  #
> > > >  
> > > >  V=             7.0.5
> > > > @@ -20,8 +20,7 @@ DEPENDS+=     git-base-[0-9]*:../../devel/gi
> > > >  
> > > >  USE_PKGLOCALEDIR=      yes
> > > >  USE_LANGUAGES=         c c++17
> > > 
> > > Should this be changed to 
> > > USE_LANGUAGES=            c c++
> > > ?
> > 
> > Don't know. Needs testing.
> > 
> > If it builds successfully with
> > USE_LANGUAGES=      c c++03
> > 
> > then that means
> > USE_LANGUAGES=      c c++
> 
> Then there's something I didn't get; I though c++17 was supposed to be in
> USE_CXX_FEATURES now, not in USE_LANGUAGES ...

USE_LANGUAGES+= c++17 does the same thing it always did
(forces the wrappers to insert -std=c++17). Sometimes it's necessary,
most of the time not.