CVS commit: pkgsrc/pkgtools/lintpkgsrc/files

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Fri Jul 29 19:00:36 UTC 2022

Modified Files:
        pkgsrc/pkgtools/lintpkgsrc/files: lintpkgsrc.pl

Log Message:
lintpkgsrc: enable Perl warnings

No functional change.


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 pkgsrc/pkgtools/lintpkgsrc/files/lintpkgsrc.pl

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/pkgtools/lintpkgsrc/files/lintpkgsrc.pl
diff -u pkgsrc/pkgtools/lintpkgsrc/files/lintpkgsrc.pl:1.22 pkgsrc/pkgtools/lintpkgsrc/files/lintpkgsrc.pl:1.23
--- pkgsrc/pkgtools/lintpkgsrc/files/lintpkgsrc.pl:1.22 Wed Apr 27 22:24:16 2022
+++ pkgsrc/pkgtools/lintpkgsrc/files/lintpkgsrc.pl      Fri Jul 29 19:00:36 2022
@@ -1,6 +1,6 @@
 #!@PERL5@
 
-# $NetBSD: lintpkgsrc.pl,v 1.22 2022/04/27 22:24:16 rillig Exp $
+# $NetBSD: lintpkgsrc.pl,v 1.23 2022/07/29 19:00:36 rillig Exp $
 
 # Written by David Brownlee <abs%netbsd.org@localhost>.
 #
@@ -13,9 +13,9 @@
 # TODO: Handle fun DEPENDS like avifile-devel with
 #                      {qt2-designer>=2.2.4,qt2-designer-kde>=2.3.1nb1}
 
-$^W = 1;
 use locale;
 use strict;
+use warnings;
 use Getopt::Std;
 use File::Find;
 use File::Basename;
@@ -38,6 +38,12 @@ my (
     %prebuilt_pkgdir_cache,       # To avoid symlink loops in prebuilt_pkgdirs
 );
 
+sub usage_and_exit();
+sub listdir($$);
+sub get_default_makefile_vars();
+sub fail($);
+sub parse_makefile_pkgsrc($);
+
 $ENV{PATH} .=
   ":/bin:/usr/bin:/sbin:/usr/sbin:${conf_prefix}/sbin:${conf_prefix}/bin";
 
@@ -171,7 +177,7 @@ sub main() {
            }
 
        # distfiles downloaded on the current system
-       @tmpdistfiles = listdir("$pkgdistdir");
+       @tmpdistfiles = listdir("$pkgdistdir", undef);
        foreach my $tmppkg (@tmpdistfiles)
            {
            if ($tmppkg ne "pkg-vulnerabilities")
@@ -561,9 +567,9 @@ sub deweycmp_extract($$) {
     $cmp;
 }
 
-sub fail(@) {
+sub fail($) {
 
-    print STDERR @_, "\n";
+    print STDERR shift(), "\n";
     exit(3);
 }