CVS commit: pkgsrc/sysutils/intel-backlight

["Tobias Nygren" <tnn%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   tnn
Date:           Mon Apr  5 10:18:36 UTC 2021

Modified Files:
        pkgsrc/sysutils/intel-backlight: Makefile

Log Message:
intel-backlight: don't set SETUID_ROOT_PERMS when UNPRIVILEGED

Requested by nia@.
In unprivileged installations the binary becomes setuid to the
unprivileged user so it doesn't work even when ran as root via sudo,
due to privilege dropping upon execution.

XXX: Arguably this fix is wrong. It doesn't make sense to me that pkgsrc
infrastructure uses mode 4511 in SETUID_ROOT_PERMS when UNPRIVILEGED.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 pkgsrc/sysutils/intel-backlight/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/sysutils/intel-backlight/Makefile
diff -u pkgsrc/sysutils/intel-backlight/Makefile:1.2 pkgsrc/sysutils/intel-backlight/Makefile:1.3
--- pkgsrc/sysutils/intel-backlight/Makefile:1.2        Sun Apr  4 10:52:40 2021
+++ pkgsrc/sysutils/intel-backlight/Makefile    Mon Apr  5 10:18:36 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2021/04/04 10:52:40 tnn Exp $
+# $NetBSD: Makefile,v 1.3 2021/04/05 10:18:36 tnn Exp $
 
 DISTNAME=      intel_backlight_fbsd-20200418
 PKGREVISION=   1
@@ -25,7 +25,11 @@ NOT_FOR_PLATFORM+=   Darwin-*-*
 INSTALLATION_DIRS+=    sbin
 INSTALLATION_DIRS+=    ${PKGMANDIR}/man1
 
+.include "../../mk/bsd.prefs.mk"
+
+.if empty(UNPRIVILEGED:MM[yY][eE][sS])
 SPECIAL_PERMS+=        sbin/intel_backlight ${SETUID_ROOT_PERMS}
+.endif
 
 do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/intel_backlight \