Re: CVS commit: pkgsrc/graphics/py-tifffile

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Wed, 10 Mar 2021 at 17:53:44 +0100, Joerg Sonnenberger wrote:
>On Tue, Mar 09, 2021 at 07:06:30AM +0100, Adam wrote:
>> David,
>> 
>> >> -PYTHON_VERSIONS_INCOMPATIBLE+= 27 36
>> >> +PYTHON_VERSIONS_INCOMPATIBLE=  27 36
>> > 
>> > Hi Adam,
>> > 
>> > Two things about PYTHON_VERSIONS_INCOMPATIBLE. I'd changed it to
the
>> > "+=" form because of joerg@'s guidance about its usage last month.
>> > 
>> >
http://mail-index.netbsd.org/pkgsrc-changes/2021/02/15/msg229136.html
>> 
>> Use += where you might add additional values to the variable
somewhere else, which it not the case here.
>> It's better to use += in Makefile.common, but in case of
PYTHON_VERSIONS_INCOMPATIBLE I doubt it might be useful.
>
>It can also be defined in mk.conf, which is one of the ways for disable
>unwanted Python versions for bulk builds.

I have questions about other variables that exhibit "=" vs. "+="
inconsistencies of approach in examples and such, but that's better
handled in a dedicated email to tech-pkg, so I'll get around to sending
that eventually.

>> > I was also curious as to why you marked 3.6 as incompatible (it
built
>> > fine for me with 3.6)? Is that because the upstream project states
they
>> > only test with 3.7 and up?
>> 
>> In setup.py, it states python_requires='>=3.7'. I believe there is a
reason behind it. :)
>> The package might build for Python 3.6, but does it work properly?
>
>Run the tests?

When I took my turn updating the package, I looked at running the tests,
but there was a dependency that doesn't exist in pkgsrc (or wip), and
after adding other TEST_DEPENDS entries and such, it required more
effort than I was willing to muster. So I thought I'd enquire.

Regards,

Dave