pkgsrc-Changes archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: pkgsrc/inputmethod
Hi,
I have overlooked some more.
DEPENDS should be BUILD_DEPENDS.
It should not be runtime dependency.
And some more fcitx5 packages require extra-cmake-modules.
Thank you.
Ryo ONODERA <ryo%tetera.org@localhost> writes:
> Hi,
>
> Thank you very much for your fix.
> The fcitx5 packages require extra-cmake-modules.
>
> However your DEPENDS line seems strange.
> Could you remove trailing slash(/) from your DEPENDS lines?
> It should be
>
> DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules
>
> instead of
>
> DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>
> 'pkglint -Wall' will warn you against this kind of mistakes.
>
>
> "Makoto Fujiwara" <mef%netbsd.org@localhost> writes:
>
>> Module Name: pkgsrc
>> Committed By: mef
>> Date: Tue Mar 2 03:04:24 UTC 2021
>>
>> Modified Files:
>> pkgsrc/inputmethod/fcitx5-anthy: Makefile
>> pkgsrc/inputmethod/fcitx5-chewing: Makefile
>> pkgsrc/inputmethod/fcitx5-hangul: Makefile
>> pkgsrc/inputmethod/fcitx5-libthai: Makefile
>> pkgsrc/inputmethod/fcitx5-lua: Makefile
>> pkgsrc/inputmethod/fcitx5-m17n: Makefile
>> pkgsrc/inputmethod/fcitx5-qt: Makefile
>> pkgsrc/inputmethod/fcitx5-rime: Makefile
>> pkgsrc/inputmethod/fcitx5-sayura: Makefile
>> pkgsrc/inputmethod/fcitx5-zhuyin: Makefile
>>
>> Log Message:
>> (inputmethod/fcitx5-*) +DEPENDS+= extra-cmake-modules, correct me for better fix
>>
>>
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.2 -r1.3 pkgsrc/inputmethod/fcitx5-anthy/Makefile
>> cvs rdiff -u -r1.2 -r1.3 pkgsrc/inputmethod/fcitx5-chewing/Makefile
>> cvs rdiff -u -r1.1 -r1.2 pkgsrc/inputmethod/fcitx5-hangul/Makefile
>> cvs rdiff -u -r1.1 -r1.2 pkgsrc/inputmethod/fcitx5-libthai/Makefile
>> cvs rdiff -u -r1.2 -r1.3 pkgsrc/inputmethod/fcitx5-lua/Makefile
>> cvs rdiff -u -r1.1 -r1.2 pkgsrc/inputmethod/fcitx5-m17n/Makefile
>> cvs rdiff -u -r1.2 -r1.3 pkgsrc/inputmethod/fcitx5-qt/Makefile
>> cvs rdiff -u -r1.1 -r1.2 pkgsrc/inputmethod/fcitx5-rime/Makefile
>> cvs rdiff -u -r1.1 -r1.2 pkgsrc/inputmethod/fcitx5-sayura/Makefile
>> cvs rdiff -u -r1.1 -r1.2 pkgsrc/inputmethod/fcitx5-zhuyin/Makefile
>>
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>>
>> Modified files:
>>
>> Index: pkgsrc/inputmethod/fcitx5-anthy/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-anthy/Makefile:1.2 pkgsrc/inputmethod/fcitx5-anthy/Makefile:1.3
>> --- pkgsrc/inputmethod/fcitx5-anthy/Makefile:1.2 Sat Feb 27 20:03:40 2021
>> +++ pkgsrc/inputmethod/fcitx5-anthy/Makefile Tue Mar 2 03:04:22 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.2 2021/02/27 20:03:40 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.3 2021/03/02 03:04:22 mef Exp $
>>
>> DISTNAME= fcitx5-anthy-5.0.3
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Anthy Japanese inputmethod for Fcitx5
>> LICENSE= gnu-gpl-v2
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-chewing/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-chewing/Makefile:1.2 pkgsrc/inputmethod/fcitx5-chewing/Makefile:1.3
>> --- pkgsrc/inputmethod/fcitx5-chewing/Makefile:1.2 Sat Feb 27 20:05:21 2021
>> +++ pkgsrc/inputmethod/fcitx5-chewing/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.2 2021/02/27 20:05:21 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.3 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-chewing-5.0.4
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Chewing engine for Fcitx5
>> LICENSE= gnu-gpl-v2
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-hangul/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-hangul/Makefile:1.1 pkgsrc/inputmethod/fcitx5-hangul/Makefile:1.2
>> --- pkgsrc/inputmethod/fcitx5-hangul/Makefile:1.1 Sat Feb 20 21:31:16 2021
>> +++ pkgsrc/inputmethod/fcitx5-hangul/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.1 2021/02/20 21:31:16 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.2 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-hangul-5.0.2
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Hangul Wrapper for Fcitx5
>> LICENSE= gnu-gpl-v2
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-libthai/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-libthai/Makefile:1.1 pkgsrc/inputmethod/fcitx5-libthai/Makefile:1.2
>> --- pkgsrc/inputmethod/fcitx5-libthai/Makefile:1.1 Sat Feb 20 21:38:43 2021
>> +++ pkgsrc/inputmethod/fcitx5-libthai/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.1 2021/02/20 21:38:43 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.2 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-libthai-5.0.2
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Thai language input method for Fcitx5
>> LICENSE= gnu-gpl-v2
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-lua/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-lua/Makefile:1.2 pkgsrc/inputmethod/fcitx5-lua/Makefile:1.3
>> --- pkgsrc/inputmethod/fcitx5-lua/Makefile:1.2 Sat Feb 27 19:40:16 2021
>> +++ pkgsrc/inputmethod/fcitx5-lua/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.2 2021/02/27 19:40:16 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.3 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-lua-5.0.3
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Lua support for fcitx5
>> LICENSE= gnu-lgpl-v2.1
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-m17n/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-m17n/Makefile:1.1 pkgsrc/inputmethod/fcitx5-m17n/Makefile:1.2
>> --- pkgsrc/inputmethod/fcitx5-m17n/Makefile:1.1 Sat Feb 20 21:41:08 2021
>> +++ pkgsrc/inputmethod/fcitx5-m17n/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.1 2021/02/20 21:41:08 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.2 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-m17n-5.0.3
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Wrapper library of m17n for Fcitx5
>> LICENSE= gnu-lgpl-v2.1
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-qt/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-qt/Makefile:1.2 pkgsrc/inputmethod/fcitx5-qt/Makefile:1.3
>> --- pkgsrc/inputmethod/fcitx5-qt/Makefile:1.2 Sat Feb 27 19:37:31 2021
>> +++ pkgsrc/inputmethod/fcitx5-qt/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.2 2021/02/27 19:37:31 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.3 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-qt-5.0.3
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://download.fcitx-im.org/
>> COMMENT= Qt5 library and IM module for fcitx5
>> LICENSE= gnu-lgpl-v2.1
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-rime/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-rime/Makefile:1.1 pkgsrc/inputmethod/fcitx5-rime/Makefile:1.2
>> --- pkgsrc/inputmethod/fcitx5-rime/Makefile:1.1 Sat Feb 20 21:17:14 2021
>> +++ pkgsrc/inputmethod/fcitx5-rime/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.1 2021/02/20 21:17:14 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.2 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-rime-5.0.4
>> CATEGORIES= inputmethod
>> @@ -11,6 +11,7 @@ COMMENT= RIME traditional Chinese input
>> LICENSE= gnu-lgpl-v2.1
>>
>> DEPENDS+= rime-luna-pinyin-[0-9]*:../../inputmethod/rime-luna-pinyin
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>>
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>>
>> Index: pkgsrc/inputmethod/fcitx5-sayura/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-sayura/Makefile:1.1 pkgsrc/inputmethod/fcitx5-sayura/Makefile:1.2
>> --- pkgsrc/inputmethod/fcitx5-sayura/Makefile:1.1 Sat Feb 20 21:43:08 2021
>> +++ pkgsrc/inputmethod/fcitx5-sayura/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.1 2021/02/20 21:43:08 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.2 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-sayura-5.0.2
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Sinhala input method for Fcitx5
>> LICENSE= gnu-gpl-v2
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> USE_CMAKE= yes
>> USE_PKGLOCALEDIR= yes
>> USE_LANGUAGES= c c++
>>
>> Index: pkgsrc/inputmethod/fcitx5-zhuyin/Makefile
>> diff -u pkgsrc/inputmethod/fcitx5-zhuyin/Makefile:1.1 pkgsrc/inputmethod/fcitx5-zhuyin/Makefile:1.2
>> --- pkgsrc/inputmethod/fcitx5-zhuyin/Makefile:1.1 Sat Feb 20 21:52:29 2021
>> +++ pkgsrc/inputmethod/fcitx5-zhuyin/Makefile Tue Mar 2 03:04:23 2021
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.1 2021/02/20 21:52:29 ryoon Exp $
>> +# $NetBSD: Makefile,v 1.2 2021/03/02 03:04:23 mef Exp $
>>
>> DISTNAME= fcitx5-zhuyin-5.0.3
>> CATEGORIES= inputmethod
>> @@ -10,6 +10,8 @@ HOMEPAGE= https://github.com/fcitx/fcitx
>> COMMENT= Libzhuyin Wrapper for Fcitx5
>> LICENSE= gnu-gpl-v2
>>
>> +DEPENDS+= extra-cmake-modules-[0-9]*:../../devel/extra-cmake-modules/
>> +
>> DISTFILES+= ${DEFAULT_DISTFILES}
>> MOREDISTFILES+= model.text.20161206.tar.gz
>> .for f in ${MOREDISTFILES}
>>
>
> --
> Ryo ONODERA // ryo%tetera.org@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3
--
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3
Home |
Main Index |
Thread Index |
Old Index