"Greg Troxel" <gdt%netbsd.org@localhost> writes:
> Module Name: pkgsrc
> Committed By: gdt
> Date: Wed Jan 20 23:56:51 UTC 2021
>
> Modified Files:
> pkgsrc/lang/python: egg.mk
>
> Log Message:
> python/egg.mk: Increase quoting
>
> When building some package, I found that the lack of quoting of
> PYVERSSUFFIX caused a syntax error due to it ending up empty. Add
> quotes, which should be harmless to others and resolved the issue.
> (Leftover from the freeze.)
I got a question summarized as "Which package? Maybe that package is
broken?" which is fair enough. I went back and tried to figure out
what happened.
This is typically about building a package with 27 when the package
doesn't support 27, This happens if one tries to make replace a
py27-foo package from last quarter when the new version no longer does
27. While devel/py-test isn't one of those this quarter, it makes a
reasonable repro recipe.
Without my change:
$ /usr/pkgsrc/devel/py-test > make PYTHON_VERSION_REQD=27 package
make: "/home/n0/gdt/pkgsrc-current/pkgsrc/lang/python/egg.mk" line 53: Malformed conditional (${PYVERSSUFFIX} == "2.7")
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/pkgsrc/devel/py-test
With my change:
$ /usr/pkgsrc/devel/py-test > make PYTHON_VERSION_REQD=27 package
ERROR: This package has set PKG_FAIL_REASON:
ERROR: No valid Python version
*** Error code 1
Stop.
make: stopped in /usr/pkgsrc/devel/py-test
While that build is destined to fail, now it gets a reasonable error
message.
Attachment:
signature.asc
Description: PGP signature