CVS commit: pkgsrc/devel/R-magrittr

["Makoto Fujiwara" <mef%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   mef
Date:           Sun Dec 13 23:51:10 UTC 2020

Modified Files:
        pkgsrc/devel/R-magrittr: Makefile distinfo

Log Message:
(devel/R-magrittr) Updated 1.5 to 2.0.1  make test fails at PDF

# magrittr 2.0.1

* Fixed issue caused by objects with certain names being present in
  the calling environment (#233).

* Fixed regression in `freduce()` with long lists (kcf-jackson/sketch#5).

# magrittr 2.0.0

## Fast and lean implementation of the pipe

The pipe has been rewritten in C with the following goals in mind:

- Minimal performance cost.
- Minimal impact on backtraces.
- No impact on reference counts.

As part of this rewrite we have changed the behaviour of the pipe to
make it closer to the implementation that will likely be included in a
future version of R. The pipe now evaluates piped expressions lazily (#120).
The main consequence of this change is that warnings and errors can
now be handled by trailing pipe calls:

```r
stop("foo") %>% try()
warning("bar") %>% suppressWarnings()
```

## Breaking changes

The pipe rewrite should generally not affect your code. We have
checked magrittr on 2800 CRAN packages and found only a dozen of
failures. The development version of magrittr has been advertised on
social media for a 3 months trial period, and no major issues were
reported. However, there are some corner cases that might require
updating your code. Below is a report of the backward
incompatibilities we found in real code to help you transition, should
you find an issue in your code.

### Behaviour of `return()` in a pipeline

In previous versions of magrittr, the behaviour of `return()` within
pipe expressions was undefined. Should it return from the current pipe
expression, from the whole pipeline, or from the enclosing function?
The behaviour that makes the most sense is to return from the
enclosing function. However, we can't make this work easily with the
new implementation, and so calling `return()` is now an error.

```r
my_function <- function(x) {
  x %>% {
    if (.) return("true")
    "false"
  }
}

my_function(TRUE)
#> Error: no function to return from, jumping to top level
```

In magrittr 1.5, `return()` used to return from the current pipe
expression. You can rewrite this to the equivalent:

```r
my_function <- function(x) {
  x %>% {
    if (.) {
      "true"
    } else {
      "false"
    }
  }
}

my_function(TRUE)
#> [1] "true"
```

For backward-compatibility we have special-cased trailing `return()`
calls as this is a common occurrence in packages:

```r
1 %>% identity() %>% return()
```

Note however that this only returns from the pipeline, not the
enclosing function (which is the historical behaviour):

```r
my_function <- function() {
  "value" %>% identity() %>% return()
  "wrong value"
}

my_function()
#> [1] "wrong value"
```

It is generally best to avoid using `return()` in a pipeline, even if
trailing.

### Failures caused by laziness

With the new lazy model for the evaluation of pipe expressions,
earlier parts of a pipeline are not yet evaluated when the last pipe
expression is called. They only get evaluated when the last function
actually uses the piped arguments:

```r
ignore <- function(x) "return value"
stop("never called") %>% ignore()
#> [1] "return value"
```

This should generally not cause problems. However we found some
functions with special behaviour, written under the assumption that
earlier parts of the pipeline were already evaluated and had already
produced side effects. This is generally incorrect behaviour because
that means that these functions do not work properly when called
with the nested form, e.g. `f(g(1))` instead of `1 %>% g() %>% f()`.

The solution to fix this is to call `force()` on the inputs to force
evaluation, and only then check for side effects:

```r
my_function <- function(data) {
  force(data)
  peek_side_effect()
}
```

Another issue caused by laziness is that if any function in a pipeline
returns invisibly, than the whole pipeline returns invisibly as well.

```r
1 %>% identity() %>% invisible()
1 %>% invisible() %>% identity()
1 %>% identity() %>% invisible() %>% identity()
```

This is consistent with the equivalent nested code. This behaviour can
be worked around in two ways. You can force visibility by wrapping the
pipeline in parentheses:

```r
my_function <- function(x) {
  (x %>% invisible() %>% identity())
}
```

Or by assigning the result to a variable and return it:

```r
my_function <- function(x) {
  out <- x %>% invisible() %>% identity()
  out
}
```

### Incorrect call stack introspection

The magrittr expressions are no longer evaluated in frames that can be
inspected by `sys.frames()` or `sys.parent()`. Using these functions
for implementing actual functionality (as opposed as debugging tools)
is likely to produce bugs. Instead, you should generally use
`parent.frame()` which works even when R code is called from
non-inspectable frames. This happens with e.g. `do.call()` and the new
C implementation of magrittr.

### Incorrect assumptions about magrittr internals

Some packages were depending on how magrittr was internally
structured. Robust code should only use the documented and exported
API of other packages.

## Bug fixes

* Can now use the placeholder `.` with the splicing operator `!!!`
  from rlang (#191).

* Piped arguments are now persistent. They can be evaluated after the
  pipeline has returned, which fixes subtle issues with function
  factories (#159, #195).


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 pkgsrc/devel/R-magrittr/Makefile
cvs rdiff -u -r1.1 -r1.2 pkgsrc/devel/R-magrittr/distinfo

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/devel/R-magrittr/Makefile
diff -u pkgsrc/devel/R-magrittr/Makefile:1.4 pkgsrc/devel/R-magrittr/Makefile:1.5
--- pkgsrc/devel/R-magrittr/Makefile:1.4        Thu Aug  8 19:53:39 2019
+++ pkgsrc/devel/R-magrittr/Makefile    Sun Dec 13 23:51:10 2020
@@ -1,14 +1,14 @@
-# $NetBSD: Makefile,v 1.4 2019/08/08 19:53:39 brook Exp $
+# $NetBSD: Makefile,v 1.5 2020/12/13 23:51:10 mef Exp $
 
 R_PKGNAME=     magrittr
-R_PKGVER=      1.5
+R_PKGVER=      2.0.1
 CATEGORIES=    devel
 
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
 COMMENT=       Forward-pipe operator for R
 LICENSE=       mit
 
-USE_LANGUAGES= # none
+USE_LANGUAGES= c
 
 .include "../../math/R/Makefile.extension"
 .include "../../mk/bsd.pkg.mk"

Index: pkgsrc/devel/R-magrittr/distinfo
diff -u pkgsrc/devel/R-magrittr/distinfo:1.1 pkgsrc/devel/R-magrittr/distinfo:1.2
--- pkgsrc/devel/R-magrittr/distinfo:1.1        Fri Jan  1 13:19:40 2016
+++ pkgsrc/devel/R-magrittr/distinfo    Sun Dec 13 23:51:10 2020
@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.1 2016/01/01 13:19:40 wen Exp $
+$NetBSD: distinfo,v 1.2 2020/12/13 23:51:10 mef Exp $
 
-SHA1 (R/magrittr_1.5.tar.gz) = 174f9188eb2c87702c3ad28f19cf6250cda021f5
-RMD160 (R/magrittr_1.5.tar.gz) = 6e188859e85d5a1af583430af7655fc71f541f2c
-SHA512 (R/magrittr_1.5.tar.gz) = d1e66bab279a08f85405fedee0efea0dc4af058e76d8c0151c620825e01a8cf766bf89eaf24a64c67cadbad05c18f780006837ae0e9ded32c2637ed4df984279
-Size (R/magrittr_1.5.tar.gz) = 200504 bytes
+SHA1 (R/magrittr_2.0.1.tar.gz) = 6f4bc79eec4f1120b0a18bd198480f44be20b625
+RMD160 (R/magrittr_2.0.1.tar.gz) = 3b6784d141d2dbde2d307bab14481d979d076a0b
+SHA512 (R/magrittr_2.0.1.tar.gz) = aa27f64ba09494a5afbe0263ec379c4a73110de45f43c6265437192c01c33a0df6dce98bd0ace021b2f380be84c040c7177b00c396842b3415d137e9e01896d2
+Size (R/magrittr_2.0.1.tar.gz) = 265580 bytes