CVS commit: pkgsrc/net/libcares

["Thomas Klausner" <wiz%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   wiz
Date:           Mon Nov 23 15:47:19 UTC 2020

Modified Files:
        pkgsrc/net/libcares: Makefile PLIST distinfo

Log Message:
libcares: update to 1.17.1.

Version 1.17.1 (19 Nov 2020)

GitHub (19 Nov 2020)
- [Brad House brought this change]

  Travis: add iOS target built with CMake (#378)

  Issue #377 suggested that CMake builds for iOS with c-ares were broken. This PR adds an automatic Travis build for iOS CMake.

  Fix By: Brad House (@bradh352)

bradh352 (18 Nov 2020)
- fix build

GitHub (18 Nov 2020)
- [Fabrice Fontaine brought this change]

  External projects were using non-public header ares_dns.h, make public again (#376)

  It appears some outside projects were relying on macros in ares_dns.h, even though it doesn't appear that header was ever meant to be public.  That said, we don't want to break external integrators 
so we should distribute this header again.

  Fix By: Fabrice Fontaine (@ffontaine)

bradh352 (17 Nov 2020)
- note that so versioning has moved to configure.ac

- note about 1.17.1

- fix sed gone wrong

GitHub (17 Nov 2020)
- [Daniel Stenberg brought this change]

  autotools cleanup (#372)

  * remove: install-sh mkinstalldirs

  They're generated when needed, no need to store in it.

  * buildconf: remove custom logic with autoreconf

  Fix By: Daniel Stenberg (@bagder)

bradh352 (17 Nov 2020)
- attempt to fix 1.17.0 release distribution issues

Version 1.17.0 (16 Nov 2020)

bradh352 (16 Nov 2020)
- 1.17.0 release prep

- ares_getaddrinfo(): duplicate hints ai_socktype and ai_protocol into output

  ai_socktype and ai_protocol were ignored from the hints input.  They are now
  duplicated into the output as expected.  Currently no sanity checks on
  proper values are taking place.

  Fixes: #317
  Fix By: Brad House (@bradh352)

- ares_parse_{a,aaaa}_reply could return larger *naddrttls than passed in

  If there are more ttls returned than the maximum provided by the requestor, then
  the *naddrttls response would be larger than the actual number of elements in
  the addrttls array.

  This bug could lead to invalid memory accesses in applications using c-ares.

  This behavior appeared to break with PR #257

  Fixes: #371
  Reported By: Momtchil Momtchev (@mmomtchev)
  Fix By: Brad House (@bradh352)

GitHub (5 Nov 2020)
- [Dustin Lundquist brought this change]

  docs: ares_set_local_ip4() uses host byte order (#368)

  Properly document brain-dead behavior of ares_set_local_ip4() using host byte order instead of expected network byte order.

  Fix By: Dustin Lundquist <d.lundquist%tempered.io@localhost>

- [Łukasz Marszał brought this change]

  empty hquery->name could lead to invalid memory access (#367)

  If hquery->name is empty (=="\0"), &hquery->name[strlen(hquery->name)-1] would point to "random" place in memory. This is causing some of my address sanitizer tests to fail.

  Fix By: Łukasz Marszał (@lmarszal)

bradh352 (28 Sep 2020)
- Fix OSSFuzz reported issue in CAA reply parsing

  OSS-Fuzz is reporting a use-of-uninitialized-value:
  https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=26012

  Reported By: David Drysdale (@daviddrysdale)

GitHub (26 Sep 2020)
- [David Hotham brought this change]

  fuzz CAA parsing (#363)

  Add fuzz support for CAA parsing

  Fix By: David Hotham (@dimbleby)

- [Daniela Sonnenschein brought this change]

  Allow parsing of CAA Resource Record (#360)

  CAA (Certification Authority Authorization) was introduced in RFC 6844.
  This has been obsoleted by RFC 8659. This commit added the possibility
  to query CAA resource records with adig and adds a parser for CAA
  records, that can be used in conjunction with ares_query(3).

  Closes Bug: #292
  Fix By: Daniela Sonnenschein (@lxdicted)

Daniel Stenberg (17 Sep 2020)
- docs: remove the html and pdf make targets

  They're rarely used in our daily work flow and mostly just add friction,

  Closes #362

bradh352 (14 Sep 2020)
- ares_process needs to always include nameser.h as it has compat

- Define T_OPT if system doesn't provide it

GitHub (12 Sep 2020)
- [Gisle Vanem brought this change]

  Change the mailman links (#358)

  Links when wrapping become misleading.  Insert newline to prevent wrapping.

  Fix By: Gisle Vanem (@gvanem)

- [Gisle Vanem brought this change]

  [adig] Update man-page for the '-x' option (#357)

  Fix By: Gisle Vanem (@gvanem)

- [Gisle Vanem brought this change]

  [adig] add '-x' option. (#356)

  Added a 'dig-style' '-x' option. Also support '-xx' for a
  IPv6 bit-string PTR query.

  Fix By: Gisle Vanem (@gvanem)

bradh352 (12 Sep 2020)
- fix indentation

- ns_t_opt -> T_OPT

GitHub (12 Sep 2020)
- [Gisle Vanem brought this change]

  Fixes for Watt-32 on djgpp + Windows (#355)

  No longer any relation to libcurl since '<libcurl-root>/packages/DOS/common.dj' is dropped.
  This Makefile.dj has been tested on Win-10 only (using the Windows hosted djgpp cross compiler).

  Fix By: Gisle Vanem (@gvanem)

- [Gisle Vanem brought this change]

  Fixes for Watt-32 on Windows and MSDOS (#354)

  Move the prototype to 'ares_private.h'.

  Fix By: Gisle Vanem (@gvanem)

bradh352 (11 Sep 2020)
- update path for include

- remove stale information

- remove stale information

Brad House (9 Sep 2020)
- silence compiler warnings

- Remove stale msvc files from makefile

GitHub (9 Sep 2020)
- [Brad House brought this change]

  Reorganize source tree (#349)

  Originally started by Daniel Stenberg (@bagder) with #123, this patch reorganizes the c-ares source tree to have a more modern layout.  It also fixes out of tree builds for autotools, and 
automatically builds the tests if tests are enabled.  All tests are passing which tests each of the supported build systems (autotools, cmake, nmake, mingw gmake).  There may be some edge cases that 
will have to be caught later on for things I'm not aware of.

  Fix By: Brad House (@bradh352)

Brad House (1 Sep 2020)
- remove CURLDEBUG as per #82

GitHub (1 Sep 2020)
- [Erik Lax brought this change]

  Detect remote DNS server does not support EDNS as per RFC 6891 (#244)

  EDNS retry should be based on FORMERR returned without an OPT RR record as per https://tools.ietf.org/html/rfc6891#section-7 rather than just treating any unexpected error condition as a reason to 
disable EDNS on the channel.

  Fix By: Erik Lax (@eriklax)

Brad House (27 Aug 2020)
- Fix for #345, don't use 'true' use 1

GitHub (27 Aug 2020)
- [Seraphime Kirkovski brought this change]

  ares_gethostbyname: Fix AF_UNSPEC support when using an ip address (#204)

  fake_hostent() was not supporting AF_UNSPEC, so when an ip address was specified when using AF_UNSPEC it would attempt to do a DNS lookup rather than returning a fake hostent using the ip address.

  Fix By: Seraphime Kirkovski (@Seraphime)

- [apenn-msft brought this change]

  Tests should use dynamic system-assigned ports rather than static port (#346)

  The c-ares test suite was hardcoded to use port 5300 (and possibly 5301, 5302) for the test suite.  Especially in containers, there may be no guarantee these ports are available and cause tests to 
fail when they could otherwise succeed.  Instead, request the system to assign a port to use dynamically.  This is now the default.  To override, the test suite still takes the "-p <port>" option as 
it always has and will honor that.

  Fix By: Anthony Penniston (@apenn-msft)

Brad House (25 Aug 2020)
- Unset members of the addr struct contain garbage values (#343)

  When generating the ares_sockaddr data by getaddrinfo() it was only filling
  in certain members while leaving others uninitialized.  This left garbage
  data if a user tried to use the unset values.  memset() the ares_sockaddr
  to 0 prior to filling in the values to prevent this.

  Reported By: @SmorkalovG
  Fix By: Brad House (@bradh352)

GitHub (24 Aug 2020)
- [Jonathan Maye-Hobbs brought this change]

  FQDN with trailing period should be queried first with larger ndot value (#345)

  If a query is performed for dynamodb.us-east-1.amazonaws.com. with ndots=5, it was attempting to search the search domains rather than just attempting the FQDN that was passed it.  This patch now 
at least attempts the FQDN first.

  We may need to determine if we should abort any further searching, however as is probably intended.

  Fix by: Jonathan Maye-Hobbs (@wheelpharoah)

- [Gisle Vanem brought this change]

  Update acountry.c country code list (#341)

  Updated country_list[]:
   * 2-letter ISO-3166 country-codes.
   * Add, rename some names + codes in accordance with latest table at https://en.wikipedia.org/wiki/ISO_3166-1.

  Fix By: Gisle Vanem (@gvanem)

- [Bulat Gaifullin brought this change]

  Test case should honor flag HAVE_WRITEV rather than WIN32 (#344)

  Test cases where not honoring the HAVE_WRITEV flag but instead using WIN32 to determine if WRITEV was available or not.  This patch fixes that.

  Fix By: Bulat Gaifullin (@bgaifullin)

Brad House (18 Jul 2020)
- Ensure c89 support

  A couple of for loops in Mac-specific code were using integer declarations
  inside a for loop.  Move the declaration to the top of the preceding
  code block to retain c89 compliance.

  Reported By: Jeffrey Walton

GitHub (2 Jul 2020)
- [Fionn Fitzmaurice brought this change]

  Avoid buffer overflow in RC4 loop comparison (#336)

  The rc4 function iterates over a buffer of size buffer_len who's maximum
  value is INT_MAX with a counter of type short that is not guaranteed to
  have maximum size INT_MAX.

  In circumstances where short is narrower than int and where buffer_len
  is larger than the maximum value of a short, it may be possible to loop
  infinitely as counter will overflow and never be greater than or equal
  to buffer_len.

  The solution is to make the comparison be between types of equal width.
  This commit defines counter as an int.

  Fix By: Fionn Fitzmaurice (@fionn)

- [anonymoushelpishere brought this change]

  Updated help information for adig, acountry, and ahost. (#334)

  Provide more descriptive help information for various utilities.

  Fix By: @anonymoushelpishere

- [lutianxiong brought this change]

  avoid read-heap-buffer-overflow (#332)

  Fix invalid read in ares_parse_soa_reply.c found during fuzzing

  Fixes Bug: #333
  Fix By: lutianxiong (@ltx2018)

- [Ivan Baidakou brought this change]

  Fix: sizeof(sizeof(addr.saX)) -> sizeof(addr.saX) in readaddrinfo (#331)

  Looks like a sed-gone-wrong, a sizeof inside of a sizeof.

  Fix By: Ivan Baidakou (@basiliscos)


To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 pkgsrc/net/libcares/Makefile
cvs rdiff -u -r1.13 -r1.14 pkgsrc/net/libcares/PLIST
cvs rdiff -u -r1.21 -r1.22 pkgsrc/net/libcares/distinfo

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/net/libcares/Makefile
diff -u pkgsrc/net/libcares/Makefile:1.28 pkgsrc/net/libcares/Makefile:1.29
--- pkgsrc/net/libcares/Makefile:1.28   Mon Jun  1 19:11:37 2020
+++ pkgsrc/net/libcares/Makefile        Mon Nov 23 15:47:19 2020
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.28 2020/06/01 19:11:37 adam Exp $
+# $NetBSD: Makefile,v 1.29 2020/11/23 15:47:19 wiz Exp $
 
-DISTNAME=      c-ares-1.16.1
+DISTNAME=      c-ares-1.17.1
 PKGNAME=       ${DISTNAME:S/c-/libc/1}
 CATEGORIES=    net
 MASTER_SITES=  https://c-ares.haxx.se/download/

Index: pkgsrc/net/libcares/PLIST
diff -u pkgsrc/net/libcares/PLIST:1.13 pkgsrc/net/libcares/PLIST:1.14
--- pkgsrc/net/libcares/PLIST:1.13      Mon Jun  1 19:11:37 2020
+++ pkgsrc/net/libcares/PLIST   Mon Nov 23 15:47:19 2020
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.13 2020/06/01 19:11:37 adam Exp $
+@comment $NetBSD: PLIST,v 1.14 2020/11/23 15:47:19 wiz Exp $
 bin/acountry
 bin/adig
 bin/ahost
@@ -13,7 +13,7 @@ lib/cmake/c-ares/c-ares-targets-noconfig
 lib/cmake/c-ares/c-ares-targets.cmake
 lib/libcares.so
 lib/libcares.so.2
-lib/libcares.so.2.4.1
+lib/libcares.so.2.4.2
 lib/libcares_static.a
 lib/pkgconfig/libcares.pc
 man/man1/acountry.1
@@ -50,6 +50,7 @@ man/man3/ares_library_initialized.3
 man/man3/ares_mkquery.3
 man/man3/ares_parse_a_reply.3
 man/man3/ares_parse_aaaa_reply.3
+man/man3/ares_parse_caa_reply.3
 man/man3/ares_parse_mx_reply.3
 man/man3/ares_parse_naptr_reply.3
 man/man3/ares_parse_ns_reply.3

Index: pkgsrc/net/libcares/distinfo
diff -u pkgsrc/net/libcares/distinfo:1.21 pkgsrc/net/libcares/distinfo:1.22
--- pkgsrc/net/libcares/distinfo:1.21   Mon Jun  1 19:11:37 2020
+++ pkgsrc/net/libcares/distinfo        Mon Nov 23 15:47:19 2020
@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.21 2020/06/01 19:11:37 adam Exp $
+$NetBSD: distinfo,v 1.22 2020/11/23 15:47:19 wiz Exp $
 
-SHA1 (c-ares-1.16.1.tar.gz) = 1111250ae1bf9adea1afc278ada1136091531d72
-RMD160 (c-ares-1.16.1.tar.gz) = 31e7f455f8e700f1879877a1f3d841b1ca395b90
-SHA512 (c-ares-1.16.1.tar.gz) = 4ac2a5d5c6da74eb1d6155c4eadc7127ab1b53a8d13caec41bd6172db5417a79f3ab022e77ba37d8b13da6893d7ced5fd8baf5cc3950a4154b4de8743ad31471
-Size (c-ares-1.16.1.tar.gz) = 1374637 bytes
+SHA1 (c-ares-1.17.1.tar.gz) = 431d5ff705db752f5d25e610827b7cb3653fc7ff
+RMD160 (c-ares-1.17.1.tar.gz) = 4e7f83785735951f2c22145743c238d78332f4cf
+SHA512 (c-ares-1.17.1.tar.gz) = b11887bcc9274d368088e1a8b6aca62414f20675cf0bc58e948f54fa04c327c39dd23cefe7509eec6397db14b550a3f6b77f5c18b3d735b3eef48ce2da1dcd00
+Size (c-ares-1.17.1.tar.gz) = 1518701 bytes