Re: CVS commit: pkgsrc/pkgtools/pkg_install

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Mon, Aug 10, 2020 at 06:19:10AM +0200, Roland Illig wrote:
> 10.08.2020 00:50:04 Joerg Sonnenberger <joerg%bec.de@localhost>:
> 
> > On Sun, Aug 09, 2020 at 09:40:43PM +0000, Roland Illig wrote:
> >> Module Name:  pkgsrc
> >> Committed By: rillig
> >> Date:   Sun Aug  9 21:40:43 UTC 2020
> >>
> >> Modified Files:
> >> pkgsrc/pkgtools/pkg_install: Makefile
> >>
> >> Log Message:
> >> pkgtools/pkg_install: fix pkglint warning about CHECK_PERMS
> >
> > I don't like this change at all. It goes in the wrong direction. The
> > point here is not that we want to ignore the results of any permission
> > checks, but that we *can't* run them.
> 
> That's exactly what the filename pattern "*" does. This pattern skips the checks completely and also doesn't add any dependency, see check-perms.mk.
> 
> Is that too surprising? It's the same that any optimizing compiler would do: dead code elimination.

I know that you introduced that pattern in March. It is not common
behavior and as I said, I strongly dislike on such magic for core
functionality. It's too easy to break.

Joerg