CVS commit: pkgsrc/www/weblint

["David H. Gutteridge" <gutteridge%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gutteridge
Date:           Wed Jul 22 21:45:41 UTC 2020

Modified Files:
        pkgsrc/www/weblint: Makefile distinfo
Added Files:
        pkgsrc/www/weblint/patches: patch-weblint

Log Message:
weblint: fix the package so it actually runs

This is a very dated package that has Perl 4 era expectations. It used
an expression that would never have worked as intended (at least, not in
any version of Perl 5) and is past deprecation in modern Perl. It also
expects Perl 4 versions of what modern Perl 5 provides as Getopt::Long
and File::Find. It was simplest to satisfy its requirements by depending
on p5-Perl4-CoreLibs, rather than rewriting multiple lines of code to
modernize to the Perl 5 versions of these modules. With these changes,
the package now runs, and passes all of its test suite. Addresses
PR pkg/55511 by Stefan Schaeckeler.


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 pkgsrc/www/weblint/Makefile
cvs rdiff -u -r1.6 -r1.7 pkgsrc/www/weblint/distinfo
cvs rdiff -u -r0 -r1.1 pkgsrc/www/weblint/patches/patch-weblint

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/www/weblint/Makefile
diff -u pkgsrc/www/weblint/Makefile:1.29 pkgsrc/www/weblint/Makefile:1.30
--- pkgsrc/www/weblint/Makefile:1.29    Sun Aug 11 13:25:10 2019
+++ pkgsrc/www/weblint/Makefile Wed Jul 22 21:45:41 2020
@@ -1,7 +1,7 @@
-# $NetBSD: Makefile,v 1.29 2019/08/11 13:25:10 wiz Exp $
+# $NetBSD: Makefile,v 1.30 2020/07/22 21:45:41 gutteridge Exp $
 
 DISTNAME=      weblint-1.020
-PKGREVISION=   7
+PKGREVISION=   8
 CATEGORIES=    www
 MASTER_SITES=  http://www.perl.com/CPAN/authors/id/NEILB/
 
@@ -12,4 +12,6 @@ COMMENT=      HTML validator and sanity check
 USE_TOOLS+=            perl:run
 INSTALLATION_DIRS+=    bin ${PKGMANDIR}/man1
 
+DEPENDS+=      p5-Perl4-CoreLibs-[0-9]*:../../devel/p5-Perl4-CoreLibs
+
 .include "../../mk/bsd.pkg.mk"

Index: pkgsrc/www/weblint/distinfo
diff -u pkgsrc/www/weblint/distinfo:1.6 pkgsrc/www/weblint/distinfo:1.7
--- pkgsrc/www/weblint/distinfo:1.6     Wed Nov  4 02:47:42 2015
+++ pkgsrc/www/weblint/distinfo Wed Jul 22 21:45:41 2020
@@ -1,7 +1,8 @@
-$NetBSD: distinfo,v 1.6 2015/11/04 02:47:42 agc Exp $
+$NetBSD: distinfo,v 1.7 2020/07/22 21:45:41 gutteridge Exp $
 
 SHA1 (weblint-1.020.tar.gz) = 445cc723ff2a25095c48aa52bd3f082fef22ba0c
 RMD160 (weblint-1.020.tar.gz) = f139b8e7c726ad21daab20288ed93b688193ac44
 SHA512 (weblint-1.020.tar.gz) = dedcbdc43dd2edd786849bf0b919d3e808440a9f1f801b24aae1c4891da33f6801ab3b8abc030cfd7ba993b32ff90a811bd08c3ceeff7a77bbdc3c9877dff2b0
 Size (weblint-1.020.tar.gz) = 41264 bytes
 SHA1 (patch-aa) = 7fae3054ede92615b3996c5a97543371e1d7d5a3
+SHA1 (patch-weblint) = 5af08f5a15ba11fd90b979c6ae785369d9cc8648

Added files:

Index: pkgsrc/www/weblint/patches/patch-weblint
diff -u /dev/null pkgsrc/www/weblint/patches/patch-weblint:1.1
--- /dev/null   Wed Jul 22 21:45:41 2020
+++ pkgsrc/www/weblint/patches/patch-weblint    Wed Jul 22 21:45:41 2020
@@ -0,0 +1,15 @@
+$NetBSD: patch-weblint,v 1.1 2020/07/22 21:45:41 gutteridge Exp $
+
+Fix incorrect test of whether a hash is defined.
+
+--- weblint.orig       1997-09-04 09:19:55.000000000 +0000
++++ weblint
+@@ -843,7 +843,7 @@ sub WebLint
+          }
+          elsif ($closing == 0 && $id =~ /^($expectArgsRE)$/io)
+          {
+-            &whine($., 'expected-attribute', $id) unless defined %args;
++            &whine($., 'expected-attribute', $id) unless %args;
+          }
+ 
+          #--------------------------------------------------------