pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/lang/zig



Hello Nikita,
some possible suggestions, probably none of them relevant at the moment
but can save possible time in the future if any of that features are
used (shared by other make fragments for other languages).

Nikita writes:
> [...]
> +USE_LANGUAGES=               c

USE_LANGUAGES is already c by default so I think this can be removed.

> +
> +do-build:
> +     cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} zig build ${_ZIGBUILDINSTALLARGS}
> +
> +do-install:
> +     cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} zig build install ${_ZIGBUILDINSTALLARGS}
> [...]

`install' target usually also honors INSTALL_ENV, so I think that would
should be `${PKGSRC_SETENV} ${INSTALL_ENV} ${MAKE_ENV} zig ...', in that
way possible zig/application.mk users can inject environment variables
only in the install target.

In general, for all targets, please also honors possible _ULIMIT_CMD by
adding a `${RUN} ${_ULIMIT_CMD}' before the `cd'.


Thanks!



Home | Main Index | Thread Index | Old Index