Re: CVS commit: pkgsrc/mk/platform

[Jonathan Perkin <jperkin%pkgsrc.org@localhost>]

* On 2020-06-02 at 17:52 BST, Roland Illig wrote:

> On 02.06.2020 18:22, Jonathan Perkin wrote:
> > Module Name:        pkgsrc
> > Committed By:       jperkin
> > Date:               Tue Jun  2 16:22:40 UTC 2020
> > 
> > Modified Files:
> >     pkgsrc/mk/platform: SunOS.mk
> > 
> > Log Message:
> > mk: bmake cannot compare non-integers numerically.
> 
> It can. It just interprets them as (arithmetic) numbers, not (version)
> numbers. Therefore 5.10 == 5.1 == 5.10000000.

Right.

> > -.if ${OS_VERSION} >= 5.10
> > +.if empty(OS_VERSION:M5.[0-9])
> 
> Not bad, this bug survived for 6 years.  I had expected it to be found
> faster.

Nobody (except me testing some things on older platforms) uses Solaris 9
or older for many years now, so not all that surprising.

There are still some others that might need attention though:

  $ git grep '^\..*if.*[<>].*[0-9]\.[0-9]'
  editors/pico/Makefile:.  if ${OS_VERSION} >= 6.5
  mail/imap-uw/Makefile:.  if ${OS_VERSION} >= 6.5
  mail/pine/Makefile:.  if ${OS_VERSION} >= 6.5
  mk/platform/OpenBSD.mk:.if ${OS_VERSION} >= 3.4
  net/siproxd/hacks.mk:.  if ${OS_VERSION} < 5.9

Cheers,

-- 
Jonathan Perkin       www.perkin.org.uk
github.com/jperkin  twitter.com/jperkin