Re: CVS commit: pkgsrc/graphics/screengrab

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello pin,
some mostly cosmetic suggestions directly inline,

pin writes:
> [...]
> Log Message:
> graphics/screengrab: Import new package
> [...]
> --- /dev/null Mon Jun  1 11:02:20 2020
> +++ pkgsrc/graphics/screengrab/Makefile       Mon Jun  1 11:02:20 2020
> @@ -0,0 +1,41 @@
> +# $NetBSD: Makefile,v 1.1 2020/06/01 11:02:20 pin Exp $
> +
> +VERSION=     2.0.1
> +DISTNAME=    screengrab-${VERSION}

Please just use:

 DISTNAME=      screengrab-2.0.1

that is simpler (avoid the VERSION variable) and the corresponding
value can be always retrieved via PKGVERSION_NOREV.

> +CATEGORIES=  graphics
> +MASTER_SITES=        ${MASTER_SITE_GITHUB:=lxqt/screengrab/releases/download/${VERSION}/}
> +EXTRACT_SUFX=        .tar.xz
> [...]

GITHUB_RELEASE should support such URLs.

Please change it to:

 MASTER_SITES=   ${MASTER_SITE_GITHUB:=lxqt/}
 GITHUB_RELEASE= ${PKGVERSION_NOREV}
 EXTRACT_SUFX=   .tar.xz


Thanks!