Re: CVS commit: pkgsrc/converters/help2man

[Roland Illig <roland.illig%gmx.de@localhost>]

On 28.05.2020 17:08, Nia Alarie wrote:
> Module Name:    pkgsrc
> Committed By:   nia
> Date:           Thu May 28 15:08:27 UTC 2020
>
> Modified Files:
>         pkgsrc/converters/help2man: Makefile
>
> Log Message:
> help2man: SOEXT may not change, needs SUBST_NOOP_OK

Do you _think_ that SUBST_NOOP_OK is needed, or did you actually get an
error message?

On NetBSD, SUBST_SED.soext is an "identity substitution" and thus
doesn't need the SUBST_NOOP_OK.

If SOEXT != "so", a subst error would mean that any of SUBST_FILES.soext
contains neither of the sed expressions.  That is unexpected, and you
should inspect SUBST_FILES.soext instead, to see why the patterns are
not found (anymore).

By the way, pkglint says:

>       SUBST_NOOP_OK.soext+=   yes
WARN: Makefile:44: The "+=" operator should only be used with lists, not
with SUBST_NOOP_OK.soext.