Re: CVS commit: pkgsrc

[Roland Illig <roland.illig%gmx.de@localhost>]

On 26.05.2020 11:45, Nia Alarie wrote:
> Module Name:    pkgsrc
> Committed By:   nia
> Date:           Tue May 26 09:45:17 UTC 2020
>
> Modified Files:
>         pkgsrc/emulators/libretro-beetle-ngp: Makefile PLIST
>         pkgsrc/emulators/libretro-beetle-pce-fast: Makefile PLIST
>         pkgsrc/emulators/libretro-beetle-psx: PLIST
>         pkgsrc/emulators/libretro-beetle-psx-hw: PLIST
>         pkgsrc/emulators/libretro-beetle-saturn: Makefile PLIST
>         pkgsrc/emulators/libretro-beetle-sgx: Makefile PLIST
>         pkgsrc/emulators/libretro-beetle-vb: Makefile PLIST
>         pkgsrc/emulators/libretro-beetle-wswan: Makefile PLIST
>         pkgsrc/emulators/libretro-bluemsx: Makefile PLIST
>         pkgsrc/emulators/libretro-bsnes-mercury: Makefile.common PLIST
>         pkgsrc/emulators/libretro-bsnes-mercury-accuracy: PLIST
>         pkgsrc/emulators/libretro-bsnes-mercury-performance: PLIST
>         pkgsrc/emulators/libretro-cap32: Makefile PLIST
>         pkgsrc/emulators/libretro-core-info: Makefile
>         pkgsrc/emulators/libretro-database: Makefile
>         pkgsrc/emulators/libretro-desmume: Makefile PLIST
>         pkgsrc/emulators/libretro-dolphin: Makefile PLIST
>         pkgsrc/emulators/libretro-fbalpha: Makefile PLIST
>         pkgsrc/emulators/libretro-fceumm: Makefile PLIST
>         pkgsrc/emulators/libretro-freeintv: Makefile PLIST
>         pkgsrc/emulators/libretro-fuse: Makefile PLIST
>         pkgsrc/emulators/libretro-gambatte: Makefile PLIST
>         pkgsrc/emulators/libretro-genesis-plus-gx: Makefile PLIST
>         pkgsrc/emulators/libretro-mame2010: Makefile PLIST
>         pkgsrc/emulators/libretro-mgba: Makefile PLIST
>         pkgsrc/emulators/libretro-mupen64plus: Makefile PLIST
>         pkgsrc/emulators/libretro-nestopia: Makefile PLIST
>         pkgsrc/emulators/libretro-np2kai: Makefile PLIST
>         pkgsrc/emulators/libretro-o2em: Makefile PLIST
>         pkgsrc/emulators/libretro-pcsx-rearmed: Makefile PLIST
>         pkgsrc/emulators/libretro-picodrive: Makefile PLIST
>         pkgsrc/emulators/libretro-ppsspp: Makefile PLIST
>         pkgsrc/emulators/libretro-prosystem: Makefile PLIST
>         pkgsrc/emulators/libretro-reicast: Makefile PLIST
>         pkgsrc/emulators/libretro-sameboy: Makefile PLIST
>         pkgsrc/emulators/libretro-snes9x: Makefile PLIST
>         pkgsrc/emulators/libretro-snes9x2005: Makefile PLIST
>         pkgsrc/emulators/libretro-snes9x2010: Makefile PLIST
>         pkgsrc/emulators/libretro-stella: Makefile PLIST
>         pkgsrc/emulators/libretro-vba-next: Makefile PLIST
>         pkgsrc/emulators/libretro-vecx: Makefile PLIST
>         pkgsrc/emulators/libretro-virtualjaguar: Makefile PLIST
>         pkgsrc/games/libretro-2048: Makefile PLIST
>         pkgsrc/games/libretro-craft: Makefile PLIST
>         pkgsrc/games/libretro-nxengine: Makefile PLIST
>
> Log Message:
> libretro-*: Support Darwin by cargo-culting SOEXT. Remove bsdtar hack.

That's a lot of duplicated code.  I would have preferred that the block
of code be defined in a single place and used wherever needed.