Re: CVS commit: pkgsrc/security/courier-authlib

[Roland Illig <roland.illig%gmx.de@localhost>]

Am May 25, 2020 7:28:39 PM UTC schrieb Jonathan Perkin <jperkin%netbsd.org@localhost>:
>Module Name:   pkgsrc
>Committed By:  jperkin
>Date:          Mon May 25 19:28:39 UTC 2020
>
>Modified Files:
>       pkgsrc/security/courier-authlib: Makefile.common
>
>Log Message:
>courier-authlib: Add missing bsd.prefs.mk include.
>
>Required before testing PKGPATH, though the use of various PKGPATH
>tests
>across the courier packages are pretty terrible and should be
>re-thought.

I know that this code is ugly.  It is only meant as an interim measure until all packages have built once in my bulk build.  After that I'm sure which file is used by which packages, and whether 
these Makefile.common make sense at all.

In this simple case of courier, it would have been possible to solve the problem by just staring at the few involved files.  I'm using that simple example as a testbed for thinking more generally 
about refactorings in pkgsrc code.

I really wish someone had already written an IntelliJ plugin that had all the features on my wishlist, see https://github.com/rillig/intellij-pkgsrc/blob/master/README.md. Then I'd just inline the 
files and be done.

I'll clean up this mess in a few days.