Re: CVS commit: pkgsrc/multimedia/ffmpeg2

[Roland Illig <roland.illig%gmx.de@localhost>]

On 24.05.2020 04:10, Mark Davies wrote:
> Module Name:    pkgsrc
> Committed By:   markd
> Date:           Sun May 24 02:10:55 UTC 2020
>
> Modified Files:
>         pkgsrc/multimedia/ffmpeg2: Makefile.common
>
> Log Message:
> ffmpeg2: SUBST_NOOP_OK.conf=yes
>
> If {PKG_SYSCONFDIR} = /etc  then this substitution
>    's,/etc/ffserver.conf,${PKG_SYSCONFDIR}/ffserver.conf,g'
> results in a noop, which is rejected - so allow.

The point why subst.mk requires SUBST_NOOP_OK in this case is that the
dot in the regular expression is not escaped and the expression would
also match /etc/ffserverXconf.

If you escape the dot, you don't need the SUBST_NOOP_OK. If you are
interested in the details, have a look at mk/scripts/subst-identity.awk
and regress/infra-unittests/subst.sh, the test case 'identity
substitution implementation'.