CVS commit: pkgsrc/games/7kaa

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Sun May  3 14:22:43 UTC 2020

Modified Files:
        pkgsrc/games/7kaa: Makefile

Log Message:
games/7kaa: build even when CFLAGS has -Werror=char-subscripts

The upstream code looks very suspicious.  It forces compilation with
-fsigned-char and then uses signed characters to index a 256-entry table,
for example in IMGbltAreaRemap.  But only in the C++ code.
The corresponding assembler code uses unsigned bytes.
I'll let them fix this bug themselves.


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 pkgsrc/games/7kaa/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/games/7kaa/Makefile
diff -u pkgsrc/games/7kaa/Makefile:1.10 pkgsrc/games/7kaa/Makefile:1.11
--- pkgsrc/games/7kaa/Makefile:1.10     Sun Mar  8 16:49:32 2020
+++ pkgsrc/games/7kaa/Makefile  Sun May  3 14:22:43 2020
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.10 2020/03/08 16:49:32 wiz Exp $
+# $NetBSD: Makefile,v 1.11 2020/05/03 14:22:43 rillig Exp $
 
 DISTNAME=      7kaa-2.15.3
 PKGREVISION=   3
@@ -29,6 +29,10 @@ CONFIGURE_ARGS+=     --disable-sdltest
 INSTALLATION_DIRS+=    share/applications
 INSTALLATION_DIRS+=    share/pixmaps
 
+# https://www.7kfans.com/forums/viewtopic.php?f=13&t=1150&p=8652
+# (bug report; requires login)
+BUILDLINK_TRANSFORM+=  rm:-Werror=char-subscripts
+
 post-extract:
        ${PREFIX}/bin/icotool -x -i 1 ${WRKSRC}/src/7k.ico -o ${WRKDIR}/7kaa.png