Re: CVS commit: pkgsrc/lang/gcc8

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2020-04-27 at 04:38 BST, Roland Illig wrote:

> The file gcc/Makefile.in does not contain GCC_TARGET_MACHINE, and there
> is no patch that adds this placeholder. The related words that actually
> appear in Makefile.in are -DTARGET_MACHINE, $(target_noncanonical),
> $(target), $(real_target_noncanonical).

FWIW, this is a quick indicator that the gcc8 package is pretty
broken.  This variable was previously used as an alias for
MACHINE_GNU_PLATFORM and used to substitute the correct value into
patch-gcc_Makefile.in.

Given that it's been broken since gcc8 was imported (just compare that
patch to gcc7) I guess either not many people use gcc8 or they're just
running into issues that they haven't diagnosed back to this yet.

Not saying this commit is wrong, just pointing out that sometimes when
something appears to do nothing it might be pointing to other
breakage.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com