CVS commit: pkgsrc/mk/check

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Fri Mar 13 06:31:43 UTC 2020

Modified Files:
        pkgsrc/mk/check: check-portability.mk

Log Message:
mk/check/check-portability: exclude REPLACE_BASH by default

Since the portability checks are concerned about bashisms, it doesn't make
sense to apply them to programs that will later be run in bash anyway.

Suggested by gdt via private mail.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 pkgsrc/mk/check/check-portability.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/mk/check/check-portability.mk
diff -u pkgsrc/mk/check/check-portability.mk:1.11 pkgsrc/mk/check/check-portability.mk:1.12
--- pkgsrc/mk/check/check-portability.mk:1.11   Wed Mar 11 19:58:45 2020
+++ pkgsrc/mk/check/check-portability.mk        Fri Mar 13 06:31:43 2020
@@ -1,4 +1,4 @@
-# $NetBSD: check-portability.mk,v 1.11 2020/03/11 19:58:45 rillig Exp $
+# $NetBSD: check-portability.mk,v 1.12 2020/03/13 06:31:43 rillig Exp $
 #
 # This file contains some checks that are applied to the configure
 # scripts to check for certain constructs that are known to cause
@@ -19,7 +19,7 @@
 #      The list of files that should be skipped in the portability
 #      check.
 #
-#      Default value: empty.
+#      Default value: ${REPLACE_BASH}
 #      Example: debian/*
 
 _VARGROUPS+=                   check-portability
@@ -30,9 +30,9 @@ _PKG_VARS.check-portability=  CHECK_PORTA
 CHECK_PORTABILITY?=            yes
 .endif
 CHECK_PORTABILITY?=            no
-CHECK_PORTABILITY_SKIP?=       # none
+CHECK_PORTABILITY_SKIP?=       ${REPLACE_BASH}
 
-.if ${CHECK_PORTABILITY:M[Yy][Ee][Ss]} != ""
+.if ${CHECK_PORTABILITY:tl} == yes && ${CHECK_PORTABILITY_SKIP} != "*"
 pre-configure-checks-hook: _check-portability
 .endif
 .PHONY: _check-portability