Re: CVS commit: pkgsrc/textproc/py-sphinxcontrib-serializinghtml

[Greg Troxel <gdt%lexort.com@localhost>]

Leonardo Taccari <leot%NetBSD.org@localhost> writes:

> Hello Greg,
>
> Greg Troxel writes:
>> [...]
>> Log Message:
>> sphinxcontrib: Limit bsdtar use to affected platforms
>>
>> Only force bsdtar if NetBSD <=8.
>>
>> (This is still being discussed on tech-pkg; apparently the previous
>> fix was not aware of the (rapidly moving around) discussion.)
>> [...]
>> +# On NetBSD, pax-as-tar fails on this distfile <= 8.  (Accomodate 5-7
>> +# even though they are unsupported.)
>> +.include "../../mk/bsd.prefs.mk"
>> +.if ${OPSYS} == NetBSD && !empty(OS_VERSION:M[5678].*)
>>  EXTRACT_USING=      bsdtar
>> +.endif
>> [...]
>
> While - after reading the tech-pkg@ email - I think that the `${OPSYS}
> == NetBSD' try to avoid possible `bsdtar' dependency on non-NetBSD
> platforms why the OS_VERSION check is added?

Because my understanding is that on 9 (release and stable) and on
current -current that's the right situation.

> There are several 9.99.x NetBSD versions that were built with pax-as-tar
> by default

I don't think pkgsrc needs to support non-current current.  If it does,
we should have a rule that current has to be more stable :-)

> and more in general users can adjust `MKBSDTAR'.

Hmm, not sure what to do about this.

> Doesn't the logic in pkgsrc/mk/tools/tools.NetBSD.mk revision 1.67
> already handle that?

So basically, you are saying that if we force bsdtar on NetBSD, then
this logic will point it at /bin/tar when that's ok, so it's ok to force
it.

(There's a separate issue which is that checking MKBSDTAR isn't really
right, compared to what's installed, because mk.conf is not necessarily
adjusted for installations of custom builds, and I guess an argument
about whether we intend to require that to be set right.)