On 06.03.2020 11:05, Leonardo Taccari wrote: > Hello Kamil, > > Kamil Rytarowski writes: >> [...] >> Log Message: >> qemu: Conditionalize NVMM for NetBSD >> >> Build NVMM support whenever there is /usr/include/nvmm.h available. >> [...] > > Couldn't this be done less intrusively by just setting: > > nvmm="" > > in emulators/qemu/patches/patch-configure and delegating the qemu > configure script in doing that instead of (re)adding similar logic in > pkgsrc? > > Can you please also give a look to the related PR pkg/55049? > > > Thanks! > We will try to upstream nvmm="" to autodetect. On 06.03.2020 14:18, Greg Troxel wrote: > I am uncomfortable with this method of conditionalizing, as it seems to > move away from repeatable builds. > > Would it be sufficient/reasonable to instead just enable the option by > default on NetBSD >= 9? There are some non-x86 users of qemu on NetBSD >= 9, but for understandable reasons !amd64 is not the primary port for this package.
Attachment:
signature.asc
Description: OpenPGP digital signature