CVS commit: pkgsrc/databases/mongodb3

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Fri Mar  6 14:22:46 UTC 2020

Modified Files:
        pkgsrc/databases/mongodb3: distinfo
        pkgsrc/databases/mongodb3/patches:
            patch-src_mongo_db_storage_mmap__v1_durop.h
            patch-src_third__party_wiredtiger_src_os__posix_os__fs.c

Log Message:
databases/mongodb3: Document patches

(This is a change only in patch comments.)


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 pkgsrc/databases/mongodb3/distinfo
cvs rdiff -u -r1.1 -r1.2 \
    pkgsrc/databases/mongodb3/patches/patch-src_mongo_db_storage_mmap__v1_durop.h
cvs rdiff -u -r1.2 -r1.3 \
    pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/databases/mongodb3/distinfo
diff -u pkgsrc/databases/mongodb3/distinfo:1.6 pkgsrc/databases/mongodb3/distinfo:1.7
--- pkgsrc/databases/mongodb3/distinfo:1.6      Thu Mar  5 01:41:51 2020
+++ pkgsrc/databases/mongodb3/distinfo  Fri Mar  6 14:22:46 2020
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.6 2020/03/05 01:41:51 gdt Exp $
+$NetBSD: distinfo,v 1.7 2020/03/06 14:22:46 gdt Exp $
 
 SHA1 (mongodb-src-r3.4.24.tar.gz) = 86909b211998f0cbc8104df774aecb3d00a01763
 RMD160 (mongodb-src-r3.4.24.tar.gz) = f7e4bfe1e2bd046f1a6c0f2695762076ffee5ae5
@@ -11,7 +11,7 @@ SHA1 (patch-src_mongo_db_query_collation
 SHA1 (patch-src_mongo_db_repl_isself.c) = 82321c918b91ce1a68ce79c14589126aca6baf96
 SHA1 (patch-src_mongo_db_repl_master__slave.cpp) = 2f37f0819a2b2743df01f6b6ab0b3013b3b7d726
 SHA1 (patch-src_mongo_db_repl_oplog__fetcher.cpp) = e12dbfbd4e70ee210cdd4eb0582661666e8eb06a
-SHA1 (patch-src_mongo_db_storage_mmap__v1_durop.h) = def5e3455a58ece20e4db0251536ff0a3b7be0b4
+SHA1 (patch-src_mongo_db_storage_mmap__v1_durop.h) = 9ccba5b5e730791d57b43f2c9d412bdf54f42a63
 SHA1 (patch-src_mongo_installer_msi_SConscript) = 78424fa10f90470dd941b900ef8fd131d28f6e65
 SHA1 (patch-src_mongo_platform_random.cpp) = 9af0fd82a653bf4f273ce107e54c5e63eaeb3b85
 SHA1 (patch-src_mongo_platform_stack__locator__netbsd.cpp) = 3f67bbae82c0f3cae410a21219589bc082e7b9b1
@@ -27,4 +27,4 @@ SHA1 (patch-src_third__party_mozjs-38_pl
 SHA1 (patch-src_third__party_mozjs-38_platform_x86__64_netbsd_include_js-config.h) = 7ddbb4e3bf4126a1be2195acc82ff859e8130a01
 SHA1 (patch-src_third__party_s2_base_port.h) = 892ce91b5aaa432f34e1e7c169b7fd6eea2a3e94
 SHA1 (patch-src_third__party_wiredtiger_SConscript) = 71fd2326a4e95fec674326225bce5ccf5793aa5a
-SHA1 (patch-src_third__party_wiredtiger_src_os__posix_os__fs.c) = 4480b5f3a58dbaa9c205925e3a67a3235917b90e
+SHA1 (patch-src_third__party_wiredtiger_src_os__posix_os__fs.c) = a9a8655421e99f9f189b299643b55ad44c5469d7

Index: pkgsrc/databases/mongodb3/patches/patch-src_mongo_db_storage_mmap__v1_durop.h
diff -u pkgsrc/databases/mongodb3/patches/patch-src_mongo_db_storage_mmap__v1_durop.h:1.1 pkgsrc/databases/mongodb3/patches/patch-src_mongo_db_storage_mmap__v1_durop.h:1.2
--- pkgsrc/databases/mongodb3/patches/patch-src_mongo_db_storage_mmap__v1_durop.h:1.1   Thu Mar  5 01:41:52 2020
+++ pkgsrc/databases/mongodb3/patches/patch-src_mongo_db_storage_mmap__v1_durop.h       Fri Mar  6 14:22:46 2020
@@ -1,6 +1,6 @@
-$NetBSD: patch-src_mongo_db_storage_mmap__v1_durop.h,v 1.1 2020/03/05 01:41:52 gdt Exp $
+$NetBSD: patch-src_mongo_db_storage_mmap__v1_durop.h,v 1.2 2020/03/06 14:22:46 gdt Exp $
 
-\todo Explain this patch.
+This file uses std::shared_ptr, but did not include the memory header as required.
 
 \todo File upstream and add upstream bugtracker URL.
 

Index: pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c
diff -u pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c:1.2 pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c:1.3
--- pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c:1.2      Thu Mar  5 01:41:52 2020
+++ pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c  Fri Mar  6 14:22:46 2020
@@ -1,7 +1,16 @@
-$NetBSD: patch-src_third__party_wiredtiger_src_os__posix_os__fs.c,v 1.2 2020/03/05 01:41:52 gdt Exp $
+$NetBSD: patch-src_third__party_wiredtiger_src_os__posix_os__fs.c,v 1.3 2020/03/06 14:22:46 gdt Exp $
 
-On NetBSD, fdatasync() fails with "Bad file descriptor".
-\todo Explain if this is only for fdatasync on directories vs files.
+Without this patch, the WT_PANIC_RET message happens, with errno EBADF.
+The fdatasync() function is specified to fail if fd is not a valid file
+descriptor that is open for writing.  We believe that it is being called
+on a directory, which is therefore invalid.  On Linux, one can use
+fdatasync() on non-writable file descriptors, but the Linux man page
+acknowledges that this is non-standard behavior.
+
+To work around this upstream bug, silently ignore fdatasync errno values
+of EBADF.  A better fix is likely to use fsync on directories instead.
+
+\todo Explore the fsync instead approach.
 
 \todo File upstream and add upstream bugtracker URL.