CVS commit: pkgsrc/pkgtools/pkg_install/files/lib

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Sun Mar  1 11:02:04 UTC 2020

Modified Files:
        pkgsrc/pkgtools/pkg_install/files/lib: plist.c

Log Message:
pkgtools/pkg_install: add errno details when remove fails

Before, it wasn't clear why removing the file failed. It could be ENOENT
or EPERM or EBUSY, and these lead to different causes.

https://mail-index.netbsd.org/pkgsrc-users/2020/02/28/msg030552.html


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 pkgsrc/pkgtools/pkg_install/files/lib/plist.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/pkgtools/pkg_install/files/lib/plist.c
diff -u pkgsrc/pkgtools/pkg_install/files/lib/plist.c:1.29 pkgsrc/pkgtools/pkg_install/files/lib/plist.c:1.30
--- pkgsrc/pkgtools/pkg_install/files/lib/plist.c:1.29  Sun Aug  2 17:56:45 2009
+++ pkgsrc/pkgtools/pkg_install/files/lib/plist.c       Sun Mar  1 11:02:04 2020
@@ -1,4 +1,4 @@
-/*     $NetBSD: plist.c,v 1.29 2009/08/02 17:56:45 joerg Exp $ */
+/*     $NetBSD: plist.c,v 1.30 2020/03/01 11:02:04 rillig Exp $        */
 
 #if HAVE_CONFIG_H
 #include "config.h"
@@ -7,7 +7,7 @@
 #if HAVE_SYS_CDEFS_H
 #include <sys/cdefs.h>
 #endif
-__RCSID("$NetBSD: plist.c,v 1.29 2009/08/02 17:56:45 joerg Exp $");
+__RCSID("$NetBSD: plist.c,v 1.30 2020/03/01 11:02:04 rillig Exp $");
 
 /*
  * FreeBSD install - a package for the installation and maintainance
@@ -697,7 +697,7 @@ delete_with_parents(const char *fname, B
 
        if (remove(fname)) {
                if (!ign_err && (!ign_nonempty || errno != ENOTEMPTY))
-                       warnx("Couldn't remove %s", fname);
+                       warn("Couldn't remove %s", fname);
                return 0;
        }
        cp = xstrdup(fname);