pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/x11/xkbcomp



Fixed!

I overlooked that I used clang, not GCC.

On 08.02.2020 09:38, Ryo ONODERA wrote:
> Hi,
> 
> "Kamil Rytarowski" <kamil%netbsd.org@localhost> writes:
> 
>> Module Name: pkgsrc
>> Committed By:        kamil
>> Date:                Thu Feb  6 11:24:20 UTC 2020
>>
>> Modified Files:
>>      pkgsrc/x11/xkbcomp: Makefile
>>
>> Log Message:
>> xkbcomp: Fix build with gcc 8.3.0/NetBSD/amd64
>>
>> Add -Wno-error=string-compare.
> 
> After this change, my NetBSD/amd64 9.99.46 (GCC 8.3.0)
> failed to build x11/xkbcomp as follows:
> 
> configure:3234: gcc -O2 -Wno-error=string-compare -D_FORTIFY_SOURCE=2 -I/usr/pkg
> /include -I/usr/pkg/include -L/usr/pkg/lib -Wl,-R/usr/pkg/lib conftest.c  >&5
> cc1: error: -Werror=string-compare: no option -Wstring-compare
> 
> And mef@'s bulk build report detects the same error:
> https://mail-index.netbsd.org/pkgsrc-bulk/2020/02/08/msg018388.html
> 
> Could you take a look at this problem?
> 
> Thank you.
> 
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.18 -r1.19 pkgsrc/x11/xkbcomp/Makefile
>>
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>>
>> Modified files:
>>
>> Index: pkgsrc/x11/xkbcomp/Makefile
>> diff -u pkgsrc/x11/xkbcomp/Makefile:1.18 pkgsrc/x11/xkbcomp/Makefile:1.19
>> --- pkgsrc/x11/xkbcomp/Makefile:1.18 Sat Jan 18 23:36:09 2020
>> +++ pkgsrc/x11/xkbcomp/Makefile      Thu Feb  6 11:24:20 2020
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.18 2020/01/18 23:36:09 rillig Exp $
>> +# $NetBSD: Makefile,v 1.19 2020/02/06 11:24:20 kamil Exp $
>>  
>>  DISTNAME=           xkbcomp-1.4.2
>>  CATEGORIES=         x11
>> @@ -16,6 +16,8 @@ PKGCONFIG_OVERRIDE=        xkbcomp.pc.in
>>  
>>  CONFIGURE_ENV+=             APP_MAN_SUFFIX=1
>>  
>> +CFLAGS+=            -Wno-error=string-compare
>> +
>>  .include "../../x11/libX11/buildlink3.mk"
>>  .include "../../x11/libxkbfile/buildlink3.mk"
>>  .include "../../x11/xorgproto/buildlink3.mk"
>>
> 


Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index