Re: CVS commit: pkgsrc/archivers/zstd

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Adam,

Adam Ciarcinski writes:
> [...]
> Log Message:
> zstd: updated to 1.4.4
> [...]

This broke py-zstandard due - at least - different ZSTD_FRAMEHEADERSIZE_MIN
and ZSTD_FRAMEHEADERSIZE_PREFIX (the macro now needs an `format'
argument):

 | [...]
 | creating build/temp.netbsd-9.99.17-amd64-3.7/zstd/dictBuilder
 | gcc -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -pipe -O2 -march=haswell -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/pkg/include -O2 -pipe -O2 -march=haswell -D_FORTIFY_SOURCE=2 -I/usr/include 
-I/usr/pkg/include -O2 -pipe -O2 -march=haswell -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/pkg/include -O2 -pipe -O2 -march=haswell -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include 
-I/usr/pkg/include/python3.7 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/python3.7 -fPIC -I/tmp/pkgsrc/archivers/py-zstandard/work/zstandard-0.12.0/zstd 
-I/tmp/pkgsrc/archivers/py-zstandard/work/zstandard-0.12.0/zstd/common -I/tmp/pkgsrc/archivers/py-zstandard/work/zstandard-0.12.0/zstd/compress 
-I/tmp/pkgsrc/archivers/py-zstandard/work/zstandard-0.12.0/zstd/decompress -I/tmp/pkgsrc/archivers/py-zstandard/work/zstandard-0.12.0/zstd/dictBuilder -I/usr/pkg/include/python3.7 -c 
build/_zstd_cffi.c -o build/temp.netbsd-9.99.17-amd64-3.7/build/_zstd_cffi.o -DZSTD_MULTITHREAD
 | build/_zstd_cffi.c: In function '_cffi_const_ZSTD_FRAMEHEADERSIZE_MIN':
 | build/_zstd_cffi.c:10143:12: error: 'ZSTD_FRAMEHEADERSIZE_MIN' undeclared (first use in this function); did you mean '_cffi_const_ZSTD_FRAMEHEADERSIZE_MIN'?
 |    int n = (ZSTD_FRAMEHEADERSIZE_MIN) <= 0;
 |             ^~~~~~~~~~~~~~~~~~~~~~~~
 |             _cffi_const_ZSTD_FRAMEHEADERSIZE_MIN
 | build/_zstd_cffi.c:10143:12: note: each undeclared identifier is reported only once for each function it appears in
 | build/_zstd_cffi.c: In function '_cffi_const_ZSTD_FRAMEHEADERSIZE_PREFIX':
 | build/_zstd_cffi.c:10150:12: error: 'ZSTD_FRAMEHEADERSIZE_PREFIX' undeclared (first use in this function); did you mean '_cffi_const_ZSTD_FRAMEHEADERSIZE_PREFIX'?
 |    int n = (ZSTD_FRAMEHEADERSIZE_PREFIX) <= 0;
 |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
 |             _cffi_const_ZSTD_FRAMEHEADERSIZE_PREFIX
 | error: command 'gcc' failed with exit status 1
 | [...]

I have temporarely switched to use the bundled zstd for py-zstandard.

Can you please give a look to it if it's possible to re-enable it to
link against py-zstandard or do you think it's better to downgrade zstd
to 1.4.3?


Thanks!