CVS commit: pkgsrc/pkgtools/pkglint4

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Mon Nov 18 08:06:59 UTC 2019

Modified Files:
        pkgsrc/pkgtools/pkglint4: Makefile
        pkgsrc/pkgtools/pkglint4/files: pkglint.pl
        pkgsrc/pkgtools/pkglint4/files/PkgLint: Shell.pm

Log Message:
pkgtools/pkglint4: update to 4.193.2

Changes since 4.193.1:

Disabled unreliable check about possible typos in variable names. For
example, in pkgtools/url2pkg the variable TEST_DEPENDS was flagged even
though it is well-known.

Disabled unreliable check about unknown shell commands. For example, in
pkgtools/pkglint4 all commands from ${PREFIX} are ok, but were still
flagged.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 pkgsrc/pkgtools/pkglint4/Makefile
cvs rdiff -u -r1.10 -r1.11 pkgsrc/pkgtools/pkglint4/files/pkglint.pl
cvs rdiff -u -r1.3 -r1.4 pkgsrc/pkgtools/pkglint4/files/PkgLint/Shell.pm

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/pkgtools/pkglint4/Makefile
diff -u pkgsrc/pkgtools/pkglint4/Makefile:1.14 pkgsrc/pkgtools/pkglint4/Makefile:1.15
--- pkgsrc/pkgtools/pkglint4/Makefile:1.14      Sun Nov 17 02:54:10 2019
+++ pkgsrc/pkgtools/pkglint4/Makefile   Mon Nov 18 08:06:58 2019
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.14 2019/11/17 02:54:10 rillig Exp $
+# $NetBSD: Makefile,v 1.15 2019/11/18 08:06:58 rillig Exp $
 
-PKGNAME=       pkglint4-4.193.1
+PKGNAME=       pkglint4-4.193.2
 CATEGORIES=    pkgtools
 
 OWNER=         rillig%NetBSD.org@localhost

Index: pkgsrc/pkgtools/pkglint4/files/pkglint.pl
diff -u pkgsrc/pkgtools/pkglint4/files/pkglint.pl:1.10 pkgsrc/pkgtools/pkglint4/files/pkglint.pl:1.11
--- pkgsrc/pkgtools/pkglint4/files/pkglint.pl:1.10      Sun Oct  6 11:45:05 2019
+++ pkgsrc/pkgtools/pkglint4/files/pkglint.pl   Mon Nov 18 08:06:58 2019
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.10 2019/10/06 11:45:05 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.11 2019/11/18 08:06:58 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -2249,7 +2249,7 @@ sub checkline_mk_varuse($$$$) {
                # Variables defined in .for loops are also ok.
 
        } else {
-               $opt_warn_extra and $line->log_warning("${varname} is used but not defined. Spelling mistake?");
+               0 and $opt_warn_extra and $line->log_warning("${varname} is used but not defined. Spelling mistake?");
        }
 
        if ($varname eq "LOCALBASE" && !$is_internal) {
@@ -3362,7 +3362,7 @@ sub checkline_mk_varassign($$$$$) {
                } elsif (exists($deprecated->{$varname}) || exists($deprecated->{$varcanon})) {
                        # Ok
                } else {
-                       $line->log_warning("${varname} is defined but not used. Spelling mistake?");
+                       0 and $line->log_warning("${varname} is defined but not used. Spelling mistake?");
                }
        }
 

Index: pkgsrc/pkgtools/pkglint4/files/PkgLint/Shell.pm
diff -u pkgsrc/pkgtools/pkglint4/files/PkgLint/Shell.pm:1.3 pkgsrc/pkgtools/pkglint4/files/PkgLint/Shell.pm:1.4
--- pkgsrc/pkgtools/pkglint4/files/PkgLint/Shell.pm:1.3 Sun Oct  6 11:06:42 2019
+++ pkgsrc/pkgtools/pkglint4/files/PkgLint/Shell.pm     Mon Nov 18 08:06:59 2019
@@ -1,4 +1,4 @@
-# $NetBSD: Shell.pm,v 1.3 2019/10/06 11:06:42 rillig Exp $
+# $NetBSD: Shell.pm,v 1.4 2019/11/18 08:06:59 rillig Exp $
 #
 # Parsing and checking shell commands embedded in Makefiles
 #
@@ -524,8 +524,8 @@ sub checkline_mk_shelltext($$) {
                                }
 
                        } else {
-                               $opt_warn_extra and $line->log_warning("Unknown shell command \"${shellword}\".");
-                               $opt_warn_extra and $line->explain_warning(
+                               0 and $opt_warn_extra and $line->log_warning("Unknown shell command \"${shellword}\".");
+                               0 and $opt_warn_extra and $line->explain_warning(
 "If you want your package to be portable to all platforms that pkgsrc",
 "supports, you should only use shell commands that are covered by the",
 "tools framework.");