Re: CVS commit: pkgsrc/devel/gmake

[Roland Illig <roland.illig%gmx.de@localhost>]

Am 25.10.2019 um 14:41 schrieb Frédéric Fauberteau:
> $ ~/pkg/bin/pkglint
> ERROR: options.mk:11: ../../devel/gettext-lib/builtin.mk must not be
> included directly. Include "../../devel/gettext-lib/buildlink3.mk" instead.
> 1 error found.
> (Run "/home/triaxx/pkg/bin/pkglint -fs" to show what can be fixed
> automatically.)
> (Run "/home/triaxx/pkg/bin/pkglint -F" to automatically fix some issues.)
>
> I included builtin.mk to test IS_BUILTIN.gettext and check if there is a
> native support for gettext. Otherwise, build devel/gmake linked to
> devel/gettext-lib leads to a circular dependency if we build ncurses
> from pkgsrc too.
>
> Is there another way to do that and appease pkglint?

A minute ago, I updated pkglint to 19.3.3, which stops complaining if
you document the rationale for directly including builtin.mk.

You can do that by adding a comment either directly at the end of that
line or in the lines above.

Thanks for the feedback,
Roland