Re: CVS commit: pkgsrc/devel/glib2

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2019-10-08 at 09:48 BST, Patrick Welche wrote:

> +CPPFLAGS.SunOS+=     -D_XOPEN_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1

This is wrong, you can't hardcode _XOPEN_SOURCE.  glib2 will now be
broken on any system using GCC 5 or newer.

USE_LANGUAGES is already set to C99 so it's highly unlikely glib2 is
actually requiring XPG4v2 specifically here, but does mean that it is
at least safe to use 600 or higher.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com