Re: CVS commit: pkgsrc/lang/rust

[Greg Troxel <gdt%lexort.com@localhost>]

"Nia Alarie" <nia%netbsd.org@localhost> writes:

> Index: pkgsrc/lang/rust/options.mk
> diff -u pkgsrc/lang/rust/options.mk:1.2 pkgsrc/lang/rust/options.mk:1.3
> --- pkgsrc/lang/rust/options.mk:1.2   Wed Aug 14 13:05:25 2019
> +++ pkgsrc/lang/rust/options.mk       Wed Aug 14 16:00:23 2019
> @@ -1,4 +1,4 @@
> -# $NetBSD: options.mk,v 1.2 2019/08/14 13:05:25 nia Exp $
> +# $NetBSD: options.mk,v 1.3 2019/08/14 16:00:23 nia Exp $
>  
>  PKG_OPTIONS_VAR=             PKG_OPTIONS.rust
>  
> @@ -7,6 +7,10 @@ PKG_OPTIONS_VAR=             PKG_OPTIONS.rust
>  # The bundled LLVM current has issues building on SunOS.
>  .if ${OPSYS} != "SunOS" && ${OPSYS} != "Darwin"
>  PKG_SUPPORTED_OPTIONS+=              rust-llvm
> +# There may be compatibility issues with base LLVM.
> +.  if !empty(HAVE_LLVM)
> +PKG_SUGGESTED_OPTIONS+=              rust-llvm
> +.  endif
>  .endif
>  
>  .include "../../mk/bsd.options.mk"

I wonder if there should be detection of whether the system pkgsrc is
running on has base llvm, rather than if it as a build host is
confrigured to build it.  But I could well be not understanding what you
did.