Re: CVS commit: pkgsrc/audio/pulseaudio

[Ryo ONODERA <ryoon%netbsd.org@localhost>]

Hi,

Leonardo Taccari <leot%NetBSD.org@localhost> writes:

> Hello Ryo,
>
> Ryo ONODERA writes:
>> [...]
>> Log Message:
>> Fix packaging on non-Linux platforms
>>
>> * PLIST_VARS should be completed on all platforms.
>> [...]
>> --- pkgsrc/audio/pulseaudio/options.mk:1.10  Mon Jul  1 10:25:24 2019
>> +++ pkgsrc/audio/pulseaudio/options.mk       Tue Jul  2 03:30:18 2019
>> @@ -1,12 +1,9 @@
>> -# $NetBSD: options.mk,v 1.10 2019/07/01 10:25:24 triaxx Exp $
>> +# $NetBSD: options.mk,v 1.11 2019/07/02 03:30:18 ryoon Exp $
>>  
>>  .include "../../comms/lirc/available.mk"
>>  
>>  PKG_OPTIONS_VAR=    PKG_OPTIONS.pulseaudio
>> -PKG_SUPPORTED_OPTIONS=      avahi fftw gsettings x11
>> -.if ${LIRC_AVAILABLE} == "yes"
>> -PKG_SUPPORTED_OPTIONS+=     lirc
>> -.endif
>> +PKG_SUPPORTED_OPTIONS=      avahi fftw gsettings x11 lirc
>>  PKG_SUGGESTED_OPTIONS=      avahi x11
>>  PLIST_VARS+=                ${PKG_SUPPORTED_OPTIONS}
>>  
>>
>
> This will add the `lirc' option also on platforms that don't support
> it and that could lead to a bit of confusion (this was discussed in
> PR pkg/54327).  Couldn't the PLIST_VARS expanded to avoid using
> PKG_SUPPORTED_OPTIONS instead?

I have just fixed like your suggestion.
Thank you.

> Thanks!

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3