Re: CVS commit: pkgsrc/audio/mp3splt-gtk

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Tue, Jun 25, 2019 at 05:43:01PM -0400, Greg Troxel wrote:
> "Amitai Schleier" <schmonz%netbsd.org@localhost> writes:
> > Modified Files:
> >     pkgsrc/audio/mp3splt-gtk: distinfo
> > Added Files:
> >     pkgsrc/audio/mp3splt-gtk/patches: patch-src_player__window.c
> >
> > Log Message:
> > #include <sys/time.h> for time_t definition on at least NetBSD-current.
> >
> > Index: pkgsrc/audio/mp3splt-gtk/patches/patch-src_player__window.c
> > diff -u /dev/null pkgsrc/audio/mp3splt-gtk/patches/patch-src_player__window.c:1.1
> > --- /dev/null       Tue Jun 25 21:25:24 2019
> > +++ pkgsrc/audio/mp3splt-gtk/patches/patch-src_player__window.c     Tue Jun 25 21:25:24 2019
> > @@ -0,0 +1,14 @@
> > +$NetBSD: patch-src_player__window.c,v 1.1 2019/06/25 21:25:24 schmonz Exp $
> > +
> > +#include <sys/time.h> for time_t definition on at least NetBSD.
> 
> POSIX says that time_t is defined in sys/types.h.  So that should be
> used instead.
> 
> https://pubs.opengroup.org/onlinepubs/7908799/xsh/systypes.h.html

That's wrong. sys/types.h is the catch-all header. The original change
(or just time.h) was much less blunt.

Joerg