Re: CVS commit: pkgsrc

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

The concept of available.mk makes sense.
LIBRSVG_USE_RUST should not be defined in graphics/librsvg/buildlink3.mk.
I have no objection to your proposal.

Thank you.


On June 2, 2019 6:37:31 PM GMT+09:00, Leonardo Taccari <leot%NetBSD.org@localhost> wrote:
>Hello Ryo,
>
>Ryo ONODERA writes:
>> [...]
>> Log Message:
>> Add graphite2 to librsvg via pango and harfbuzz
>>
>> librsvg with pango and harfbuzz with graphite2 is required for
>libreoffice.
>> librsvg-c has the problem on NetBSD and libreoffice uses internal
>static
>> harfbuzz library. Rust-based librsvg has no problem and libreoffice
>use
>> dynamic harfbuzz from fonts/harfbuzz.
>>
>> Bump PKGREVISIONs.
>> [...]
>
>Shouldn't this check be made based on LIBRSVG_USE_RUST variable
>(instead of PLATFORM_SUPPORTS_RUST)? (Otherwise possible user's
>preferences about librsvg can interfere with that.)
>
>I still haven't looked at it in details but I think that the current
>LIBRSVG_USE_RUST is limited to buildlink3 logic while librsvg is
>often used as a tool dependency too (for rsvg-convert) and like in
>this case only the LIBRSVG_USE_RUST value is needed.  I think it's
>probably worth to separate the logic il graphics/librsvg/buildlink3.mk
>in two new files:
>
> - available.mk: to just define and handle LIBRSVG_USE_RUST variable
> - tool.mk:      to make librsvg as a tool dependency (ATM all
>                 BUILD_DEPENDS and TOOL_DEPENDS hardcodes
>                graphics/librsvg ignoring LIBRSVG_USE_RUST.  AFAICS the
>                only exception is x11/mate-desktop that despite needing
>                 librsvg as a tool dependency picks it up via bl3 so
>                 LIBRSVG_USE_RUST is honored)
>
>If noone beat me I hope to discuss a possible patch ASAP in tech-pkg@.

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3