CVS commit: pkgsrc/lang/clang-tools-extra

["Adam Ciarcinski" <adam%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   adam
Date:           Sun Jun  2 08:41:18 UTC 2019

Modified Files:
        pkgsrc/lang/clang-tools-extra: Makefile distinfo
        pkgsrc/lang/clang-tools-extra/patches:
            patch-tools_extra_clangd_CMakeLists.txt
Added Files:
        pkgsrc/lang/clang-tools-extra: PLIST.Darwin

Log Message:
clang-tools-extra: updated to 8.0.0

Clang Tools 8.0.0:

Improvements to clangd

clangd now adds namespace qualifiers in code completion, for example, if you type “vec”, the list of completions will include “std::vector”.

When a global index is available, clangd will use it to augment the results of “go to definition” and “find references” queries. Global index also enables global code completion, which suggests 
symbols that are not imported in the current file and automatically inserts the missing #include directives.

clangd stores the symbol index on disk in a new compact binary serialization format. It is 10x more compact than YAML and 40% more compact than gzipped YAML.

clangd has a new efficient symbol index suitable for complex and fuzzy queries and large code bases (e.g., LLVM, Chromium). This index is used for code completion, go to definition, and 
cross-references. The architecture of the index allows for complex and fuzzy retrieval criteria and sophisticated scoring.

clangd has a new LSP extension that communicates information about activity on clangd’s per-file worker thread. This information can be displayed to users to let them know that the language server is 
busy with something. For example, in clangd, building the AST blocks many other operations.

clangd has a new LSP extension that allows the client to supply the compilation commands over LSP, instead of finding compile_commands.json on disk.

clangd has a new LSP extension that allows the client to request fixes to be sent together with diagnostics, instead of asynchronously.

clangd has a new LSP extension that allows the client to resolve a symbol in a light-weight manner, without retrieving further information (like definition location, which may require consulting an 
index).

Improvements to clang-query

A new command line parameter --preload was added to run commands from a file and then start the interactive interpreter.

The command q can was added as an alias for quit to exit the clang-query interpreter.

It is now possible to bind to named values (the result of let expressions).

It is now possible to write comments in clang-query code. This is primarily useful when using script-mode. Comments are all content following the # character on a line.

The new set print-matcher true command now causes clang-query to print the evaluated matcher together with the resulting bindings.

A new output mode detailed-ast was added to clang-query. The existing dump output mode is now a deprecated alias for detailed-ast

Output modes can now be enabled or disabled non-exclusively.

Improvements to clang-tidy

New abseil-duration-comparison check.

Checks for comparisons which should be done in the absl::Duration domain instead of the float of integer domains.

New abseil-duration-division check.

Checks for uses of absl::Duration division that is done in a floating-point context, and recommends the use of a function that returns a floating-point value.

New abseil-duration-factory-float check.

Checks for cases where the floating-point overloads of various absl::Duration factory functions are called when the more-efficient integer versions could be used instead.

New abseil-duration-factory-scale check.

Checks for cases where arguments to absl::Duration factory functions are scaled internally and could be changed to a different factory function.

New abseil-duration-subtraction check.

Checks for cases where subtraction should be performed in the absl::Duration domain.

New abseil-faster-strsplit-delimiter check.

Finds instances of absl::StrSplit() or absl::MaxSplits() where the delimiter is a single character string literal and replaces with a character.

New abseil-no-internal-dependencies check.

Gives a warning if code using Abseil depends on internal details.

New abseil-no-namespace check.

Ensures code does not open namespace absl as that violates Abseil’s compatibility guidelines.

New abseil-redundant-strcat-calls check.

Suggests removal of unnecessary calls to absl::StrCat when the result is being passed to another absl::StrCat or absl::StrAppend.

New abseil-str-cat-append check.

Flags uses of absl::StrCat() to append to a std::string. Suggests absl::StrAppend() should be used instead.

New abseil-upgrade-duration-conversions check.

Finds calls to absl::Duration arithmetic operators and factories whose argument needs an explicit cast to continue compiling after upcoming API changes.

New bugprone-too-small-loop-variable check.

Detects those for loops that have a loop variable with a “too small” type which means this type can’t represent all values which are part of the iteration range.

New cppcoreguidelines-macro-usage check.

Finds macro usage that is considered problematic because better language constructs exist for the task.

New google-objc-function-naming check.

Checks that function names in function declarations comply with the naming conventions described in the Google Objective-C Style Guide.

New misc-non-private-member-variables-in-classes check.

Finds classes that not only contain the data (non-static member variables), but also have logic (non-static member functions), and diagnoses all member variables that have any other scope other than 
private.

New modernize-avoid-c-arrays check.

Finds C-style array types and recommend to use std::array<> / std::vector<>.

New modernize-concat-nested-namespaces check.

Checks for uses of nested namespaces in the form of namespace a { namespace b { ... }} and offers change to syntax introduced in C++17 standard: namespace a::b { ... }.

New modernize-deprecated-ios-base-aliases check.

Detects usage of the deprecated member types of std::ios_base and replaces those that have a non-deprecated equivalent.

New modernize-use-nodiscard check.

Adds [[nodiscard]] attributes (introduced in C++17) to member functions to highlight at compile time which return values should not be ignored.

New readability-const-return-type check.

Checks for functions with a const-qualified return type and recommends removal of the const keyword.

New readability-isolate-decl check.

Detects local variable declarations declaring more than one variable and tries to refactor the code to one statement per declaration.

New readability-magic-numbers check.

Detects usage of magic numbers, numbers that are used as literals instead of introduced via constants or symbols.

New readability-redundant-preprocessor check.

Finds potentially redundant preprocessor directives.

New readability-uppercase-literal-suffix check.

Detects when the integral literal or floating point literal has non-uppercase suffix, and suggests to make the suffix uppercase. The list of destination suffixes can be optionally provided.

New alias cert-dcl16-c to readability-uppercase-literal-suffix added.

New alias cppcoreguidelines-avoid-c-arrays to modernize-avoid-c-arrays added.

New alias cppcoreguidelines-non-private-member-variables-in-classes to misc-non-private-member-variables-in-classes added.

New alias hicpp-avoid-c-arrays to modernize-avoid-c-arrays added.

New alias hicpp-uppercase-literal-suffix to readability-uppercase-literal-suffix added.

The cppcoreguidelines-narrowing-conversions check now detects more narrowing conversions: - integer to narrower signed integer (this is compiler implementation defined), - integer - floating point 
narrowing conversions, - floating point - integer narrowing conversions, - constants with narrowing conversions (even in ternary operator).

The objc-property-declaration check now ignores the Acronyms and IncludeDefaultAcronyms options.

The readability-redundant-smartptr-get check does not warn about calls inside macros anymore by default.

The readability-uppercase-literal-suffix check does not warn about literal suffixes inside macros anymore by default.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 pkgsrc/lang/clang-tools-extra/Makefile
cvs rdiff -u -r0 -r1.1 pkgsrc/lang/clang-tools-extra/PLIST.Darwin
cvs rdiff -u -r1.1 -r1.2 pkgsrc/lang/clang-tools-extra/distinfo
cvs rdiff -u -r1.1 -r1.2 \
    pkgsrc/lang/clang-tools-extra/patches/patch-tools_extra_clangd_CMakeLists.txt

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/lang/clang-tools-extra/Makefile
diff -u pkgsrc/lang/clang-tools-extra/Makefile:1.2 pkgsrc/lang/clang-tools-extra/Makefile:1.3
--- pkgsrc/lang/clang-tools-extra/Makefile:1.2  Thu Apr 25 07:33:02 2019
+++ pkgsrc/lang/clang-tools-extra/Makefile      Sun Jun  2 08:41:18 2019
@@ -1,9 +1,8 @@
-# $NetBSD: Makefile,v 1.2 2019/04/25 07:33:02 maya Exp $
+# $NetBSD: Makefile,v 1.3 2019/06/02 08:41:18 adam Exp $
 
 .include "../../lang/clang/Makefile.common"
 
 PKGNAME=       ${DISTNAME:S/cfe/clang-tools-extra/:S/.src//}
-PKGREVISION=   1
 
 COMMENT=       Extra Clang tools
 

Index: pkgsrc/lang/clang-tools-extra/distinfo
diff -u pkgsrc/lang/clang-tools-extra/distinfo:1.1 pkgsrc/lang/clang-tools-extra/distinfo:1.2
--- pkgsrc/lang/clang-tools-extra/distinfo:1.1  Wed Mar 27 06:24:22 2019
+++ pkgsrc/lang/clang-tools-extra/distinfo      Sun Jun  2 08:41:18 2019
@@ -1,11 +1,11 @@
-$NetBSD: distinfo,v 1.1 2019/03/27 06:24:22 adam Exp $
+$NetBSD: distinfo,v 1.2 2019/06/02 08:41:18 adam Exp $
 
-SHA1 (cfe-7.0.1.src.tar.xz) = 427e12762836d808583fb4149c033d02de0a8db2
-RMD160 (cfe-7.0.1.src.tar.xz) = 914adafed7c97e5ebab15a437670906c404cb8bd
-SHA512 (cfe-7.0.1.src.tar.xz) = df2f38153ebdc261bcfa6a569567f759bbb1a803192882a9d4eca55a47878166ac9057151a94ad341dc1281136547e4faa783a68070dfde2307b48cacd4b9194
-Size (cfe-7.0.1.src.tar.xz) = 12488668 bytes
-SHA1 (clang-tools-extra-7.0.1.src.tar.xz) = 6f4048482c4cf1818133120565c2dcd1d3a62747
-RMD160 (clang-tools-extra-7.0.1.src.tar.xz) = d0ec60e76157a99e7d6d5f04f7b7eda56ba450da
-SHA512 (clang-tools-extra-7.0.1.src.tar.xz) = f0aa73217560f952261201e9049310e4a038bc5d4b4120a4c5d13a42aacfbbfe702f1891745755e1702269751d3df19237271caecba43c810a6f50d35494c798
-Size (clang-tools-extra-7.0.1.src.tar.xz) = 901368 bytes
-SHA1 (patch-tools_extra_clangd_CMakeLists.txt) = f075acff791edd9b05e98c5297c1f8fde06ae9fe
+SHA1 (cfe-8.0.0.src.tar.xz) = 3cb1e10af3955174a3ca5e560f674f24fac2a02f
+RMD160 (cfe-8.0.0.src.tar.xz) = bd4dd523edcde136156b773cc66bfad1fc52dbc4
+SHA512 (cfe-8.0.0.src.tar.xz) = 98e540222719716985e5d8439116e47469cb01201ea91d1da7e46cb6633da099688d9352c3b65e5c5f660cbbae353b3d79bb803fc66b3be663f2b04b1feed1c3
+Size (cfe-8.0.0.src.tar.xz) = 12868468 bytes
+SHA1 (clang-tools-extra-8.0.0.src.tar.xz) = f341ba17494ba756fd404b2744e6f5991b50389f
+RMD160 (clang-tools-extra-8.0.0.src.tar.xz) = 326bfe3cbcdf701f3a9f6722823877d00679626f
+SHA512 (clang-tools-extra-8.0.0.src.tar.xz) = 434e4cb7b76f89b0a0af25f05f32f2f2e8edb9e9f14547be845df75f5032c1d9dbf475be408bb989c476ec667c10af54a15d40e42559b05e52d24c5fd416b517
+Size (clang-tools-extra-8.0.0.src.tar.xz) = 1996156 bytes
+SHA1 (patch-tools_extra_clangd_CMakeLists.txt) = a9c3c2686f04a06eef10c1ebc14f0c95fef4a9e7

Index: pkgsrc/lang/clang-tools-extra/patches/patch-tools_extra_clangd_CMakeLists.txt
diff -u pkgsrc/lang/clang-tools-extra/patches/patch-tools_extra_clangd_CMakeLists.txt:1.1 pkgsrc/lang/clang-tools-extra/patches/patch-tools_extra_clangd_CMakeLists.txt:1.2
--- pkgsrc/lang/clang-tools-extra/patches/patch-tools_extra_clangd_CMakeLists.txt:1.1   Wed Mar 27 06:24:22 2019
+++ pkgsrc/lang/clang-tools-extra/patches/patch-tools_extra_clangd_CMakeLists.txt       Sun Jun  2 08:41:18 2019
@@ -1,11 +1,11 @@
-$NetBSD: patch-tools_extra_clangd_CMakeLists.txt,v 1.1 2019/03/27 06:24:22 adam Exp $
+$NetBSD: patch-tools_extra_clangd_CMakeLists.txt,v 1.2 2019/06/02 08:41:18 adam Exp $
 
 Do not look for libatomic.
 
---- tools/extra/clangd/CMakeLists.txt.orig     2019-03-25 08:39:03.000000000 +0000
+--- tools/extra/clangd/CMakeLists.txt.orig     2019-01-16 00:24:22.000000000 +0000
 +++ tools/extra/clangd/CMakeLists.txt
-@@ -3,9 +3,6 @@ set(LLVM_LINK_COMPONENTS
-   )
+@@ -16,9 +16,6 @@ if(CLANG_BUILT_STANDALONE)
+ endif()
  
  set(CLANGD_ATOMIC_LIB "")
 -if(NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB)

Added files:

Index: pkgsrc/lang/clang-tools-extra/PLIST.Darwin
diff -u /dev/null pkgsrc/lang/clang-tools-extra/PLIST.Darwin:1.1
--- /dev/null   Sun Jun  2 08:41:18 2019
+++ pkgsrc/lang/clang-tools-extra/PLIST.Darwin  Sun Jun  2 08:41:18 2019
@@ -0,0 +1,5 @@
+@comment $NetBSD: PLIST.Darwin,v 1.1 2019/06/02 08:41:18 adam Exp $
+bin/clangd-xpc-test-client
+lib/libClangdXPCLib.so
+lib/libclangdXpcJsonConversions.a
+lib/libclangdXpcTransport.a