Re: CVS commit: pkgsrc/devel/ocaml-fmt

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, May 29, 2019 at 03:23:29AM +0000, Makoto Fujiwara wrote:
> Module Name:  pkgsrc
> Committed By: mef
> Date:         Wed May 29 03:23:28 UTC 2019
> 
> Modified Files:
>       pkgsrc/devel/ocaml-fmt: Makefile
> 
> Log Message:
> (devel/ocaml-fmt) Add misc/ocaml-topkg/buildlink3.mk to fix following problem
> 
>      ===> Creating toolchain wrappers for ocaml-fmt-0.8.5
>      ERROR: ocaml-topkg>=1.0.0 is not installed; can't buildlink files.
>      *** Error code 1

This error means that ocaml-fmt depends on foo foo's bl3.mk includes
misc/ocaml-topkg/buildlink3.mk but foo does not depend on ocaml-topkg
(any longer?).

The change is just hiding the issue.

The fix is to fix foo's bl3.mk file.

In this case, the broken bl3.mk file seems to be mk/ocaml.mk.

Jaap, can you please find a proper fix?

Thanks,
 Thomas

  
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.2 -r1.3 pkgsrc/devel/ocaml-fmt/Makefile
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

> Modified files:
> 
> Index: pkgsrc/devel/ocaml-fmt/Makefile
> diff -u pkgsrc/devel/ocaml-fmt/Makefile:1.2 pkgsrc/devel/ocaml-fmt/Makefile:1.3
> --- pkgsrc/devel/ocaml-fmt/Makefile:1.2       Tue Mar 12 17:53:44 2019
> +++ pkgsrc/devel/ocaml-fmt/Makefile   Wed May 29 03:23:28 2019
> @@ -1,4 +1,4 @@
> -# $NetBSD: Makefile,v 1.2 2019/03/12 17:53:44 jaapb Exp $
> +# $NetBSD: Makefile,v 1.3 2019/05/29 03:23:28 mef Exp $
>  
>  DISTNAME=    fmt-0.8.5
>  PKGNAME=     ocaml-${DISTNAME}
> @@ -19,6 +19,7 @@ OCAML_USE_OPAM=     yes
>  .include "../../devel/ocamlbuild/buildlink3.mk"
>  .include "../../devel/ocaml-cmdliner/buildlink3.mk"
>  .include "../../devel/ocaml-result/buildlink3.mk"
> +.include "../../misc/ocaml-topkg/buildlink3.mk"
>  .include "../../textproc/ocaml-uchar/buildlink3.mk"
>  .include "../../mk/ocaml.mk"
>  .include "../../mk/bsd.pkg.mk"
>