pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/bootstrap



Am 07.05.2019 um 15:17 schrieb Amitai Schleier:
> On 1 May 2019, at 14:29, Roland Illig wrote:
>
>> Log Message:
>> bootstrap: prevent pkgsrcdir, prefix and wrkdir from being symlinks
>>
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.262 -r1.263 pkgsrc/bootstrap/bootstrap
>
> This change appears to prevent pkgtools/pkg_comp from getting past
> bootstrap. Reverting lets pkg_comp proceed normally. Haven't
> investigated beyond that, and am not sure what needs fixing, but wanted
> to report the problem.

The only chance of getting stuck is the following loop:

_dir="/whatever/path/no/matter/how deeply/nested"
while [ ! -d "$_dir" ]; do
  _dir=${_dir%/*}
done

This loop is only ever entered when the path starts with a slash.

I assumed that "/" is always a directory. Might this assumption be wrong
in some strange edge case?

Amitai, can you put a "set -x" above this loop in bootstrap/bootstrap
and try again?



Home | Main Index | Thread Index | Old Index