Re: CVS commit: pkgsrc/wm/blackbox70

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Wed, 2 Jan 2019 at 08:46:33 +0100, Joerg Sonnenberger wrote:
> On Fri, Dec 28, 2018 at 02:52:46PM -0500, David H. Gutteridge wrote:
> > > Module Name:    pkgsrc
> > > Committed By:   joerg
> > > Date:           Thu Dec 27 15:10:17 UTC 2018
> > > 
> > > Modified Files:
> > >         pkgsrc/wm/blackbox70: distinfo
> > > Added Files:
> > >         pkgsrc/wm/blackbox70/patches: patch-src_main.cc
> > > 
> > > Log Message:
> > > Add missing include.
> > > 
> > > 
> > > To generate a diff of this commit:
> > > cvs rdiff -u -r1.10 -r1.11 pkgsrc/wm/blackbox70/distinfo
> > > cvs rdiff -u -r0 -r1.1 pkgsrc/wm/blackbox70/patches/patch-src_main.cc
> > 
> > Hi Joerg,
> > 
> > I see you commited one patch, but the distinfo you updated contains a
> > reference to a second patch:
> > 
> > +SHA1 (patch-m4_gettext.m4) = 4b87f4ab9f1fc0ed6b71e3373990eedc34fa8789
> > 
> > I'm wondering if that was intended to fix the build breakage on NetBSD?
> > (http://gnats.netbsd.org/53706). If not, I have an alternate fix I can
> > commit for that (slightly different than what I'd suggested in that PR,
> > setting BROKEN_GETTEXT_DETECTION=yes).
> 
> That change shouldn't be necessary after the fix to gettext-m4.

With devel/gettext-m4 0.19.8.1nb1 installed, and wm/blackbox70's make
file reverted to 1.16, I'm still getting the same failure during the
packaging phase as before on NetBSD 8.0_STABLE. I need both the changes
I made in 1.17 in order to complete packaging. Have I misunderstood
something? (By which I mean, it's entirely possible I have.)

Dave