pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/x11/py-qt5



Mark Davies <mark%ecs.vuw.ac.nz@localhost> writes:

> On 23/01/18 05:37, Darrin B. Jewell wrote:
>>>> Log Message:
>>>> if PYPKGPREFIX is not py27, disable QtWebKit and remove it as a dependency
>>>>
>>>
>>> What's the reason though?
>> 
>> 
>> Ah. I could have made that clearer in the commit message.
>> 
>> x11/qt5-qtwebkit/Makefile has 
>>   PYTHON_VERSIONS_ACCEPTED=       27
>> 
>> and only works with python 2.7
>
> But that's just a build dependency for qt5-qtwebkit itself, so why is it
> better to remove QtWebKit as a dependency rather than have py36-qt5
> require both python3.6 and python2.7 to be on the system -- if building
> from source?
>
> Note that I've just fixed qt5-qtwebkit's buildlink3.mk to not mention
> python or ruby as they aren't needed to compile link or run with it.
>
> cheers
> mark

I did not realize it was a build only dependency.
I'll revert the commit.

Darrin



Home | Main Index | Thread Index | Old Index