Re: CVS commit: pkgsrc/meta-pkgs/boost

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Sat, Sep 02, 2017 at 11:54:37AM +0000, maya%netbsd.org@localhost wrote:
> On Sat, Sep 02, 2017 at 10:42:12AM +0000, Manuel Bouyer wrote:
> > Module Name:        pkgsrc
> > Committed By:       bouyer
> > Date:               Sat Sep  2 10:42:12 UTC 2017
> > 
> > Modified Files:
> >     pkgsrc/meta-pkgs/boost: distinfo
> > Added Files:
> >     pkgsrc/meta-pkgs/boost/patches:
> >         patch-libs_context_src_asm_jump_arm_aapcs_elf_gas.S
> >         patch-libs_context_src_asm_ontop_arm_aapcs_elf_gas.S
> > 
> > Log Message:
> > If we have a VFP, assume it is VFP3. In the default mode on NetBSD, the
> > assembler complains:
> > libs/context/src/asm/ontop_arm_aapcs_elf_gas.S:55: Error: selected processor does not support `vstmia sp,{d8-d15}' in ARM mode
> > libs/context/src/asm/ontop_arm_aapcs_elf_gas.S:69: Error: selected processor does not support `vldmia sp,{d8-d15}' in ARM mode
> > 
> > XXX what about VFP4 ?
> > 
> > Should fix PR pkg/52425.
> 
> Hello bouyer,
> 
> It seems ARM has two variants: VFPv3-D32 and VFPv3-D16.

and also VFPv4

> D16 is the common denominator, but D32 has twice as many registers.
> I'm not an expert on ARM, but it sounds like it is assuming D16?
> 
> It may fail unexpectedly if built for VFPv3-D32 :-(

or maybe VFPv4, or maybe neon. But I'm not familiar with arm FP variants,
so I don't know how safe is this code for various FP variants.

> 
> Also, vstmia is VFPv3, and will SIGILL on VFPv1 (the original report
> was for v6).

v6hf actually. I don't know if there exists, or if we support v6hf or v7hf
architectures that are not compatible with VFPv3

> 
> Another option is to disable boost-context, which we are doing for some
> architectures.

I'd prefer to keep proper arm support.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--