CVS commit: pkgsrc/mail/qmail-run

["Amitai Schleier" <schmonz%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   schmonz
Date:           Sat Aug  5 03:03:17 UTC 2017

Modified Files:
        pkgsrc/mail/qmail-run: Makefile
        pkgsrc/mail/qmail-run/files: qmail.sh qmailofmipd.sh qmailpop3d.sh
            qmailqread.sh qmailsend.sh qmailsmtpd.sh

Log Message:
Fix "reload" and "hup" (broken in 20170729).

For all services where we set procname, prefix "nb". This makes it even
harder for observers to fail to notice that this isn't a Life with qmail
install, and happens to match the log tags already being applied.

Bump version.


To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1.43 pkgsrc/mail/qmail-run/Makefile
cvs rdiff -u -r1.6 -r1.7 pkgsrc/mail/qmail-run/files/qmail.sh
cvs rdiff -u -r1.7 -r1.8 pkgsrc/mail/qmail-run/files/qmailofmipd.sh
cvs rdiff -u -r1.15 -r1.16 pkgsrc/mail/qmail-run/files/qmailpop3d.sh \
    pkgsrc/mail/qmail-run/files/qmailsmtpd.sh
cvs rdiff -u -r1.12 -r1.13 pkgsrc/mail/qmail-run/files/qmailqread.sh
cvs rdiff -u -r1.11 -r1.12 pkgsrc/mail/qmail-run/files/qmailsend.sh

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/mail/qmail-run/Makefile
diff -u pkgsrc/mail/qmail-run/Makefile:1.42 pkgsrc/mail/qmail-run/Makefile:1.43
--- pkgsrc/mail/qmail-run/Makefile:1.42 Fri Aug  4 06:35:28 2017
+++ pkgsrc/mail/qmail-run/Makefile      Sat Aug  5 03:03:17 2017
@@ -1,7 +1,7 @@
-# $NetBSD: Makefile,v 1.42 2017/08/04 06:35:28 schmonz Exp $
+# $NetBSD: Makefile,v 1.43 2017/08/05 03:03:17 schmonz Exp $
 #
 
-DISTNAME=              qmail-run-20170804
+DISTNAME=              qmail-run-20170805
 CATEGORIES=            mail
 MASTER_SITES=          # empty
 DISTFILES=             # empty

Index: pkgsrc/mail/qmail-run/files/qmail.sh
diff -u pkgsrc/mail/qmail-run/files/qmail.sh:1.6 pkgsrc/mail/qmail-run/files/qmail.sh:1.7
--- pkgsrc/mail/qmail-run/files/qmail.sh:1.6    Sun Jul 30 03:05:59 2017
+++ pkgsrc/mail/qmail-run/files/qmail.sh        Sat Aug  5 03:03:17 2017
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: qmail.sh,v 1.6 2017/07/30 03:05:59 schmonz Exp $
+# $NetBSD: qmail.sh,v 1.7 2017/08/05 03:03:17 schmonz Exp $
 #
 # @PKGNAME@ master script for administrators to control qmail
 # services. Usage resembles the qmailctl script from "Life with qmail".
@@ -75,7 +75,7 @@ name="qmail"
 start_cmd="forward_commands"
 stop_cmd="reverse_commands"
 doqueue_cmd="qmailrcd qmailsend"; alrm_cmd=${doqueue_cmd}; flush_cmd=${doqueue_cmd}
-reload_cmd="qmailrcd send"; hup_cmd=${reload_cmd}
+reload_cmd="qmailrcd qmailsend"; hup_cmd=${reload_cmd}
 status_cmd="forward_commands"; stat_cmd=${status_cmd}
 pause_cmd="reverse_commands"
 cont_cmd="forward_commands"

Index: pkgsrc/mail/qmail-run/files/qmailofmipd.sh
diff -u pkgsrc/mail/qmail-run/files/qmailofmipd.sh:1.7 pkgsrc/mail/qmail-run/files/qmailofmipd.sh:1.8
--- pkgsrc/mail/qmail-run/files/qmailofmipd.sh:1.7      Fri Jul 21 04:08:15 2017
+++ pkgsrc/mail/qmail-run/files/qmailofmipd.sh  Sat Aug  5 03:03:17 2017
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: qmailofmipd.sh,v 1.7 2017/07/21 04:08:15 schmonz Exp $
+# $NetBSD: qmailofmipd.sh,v 1.8 2017/08/05 03:03:17 schmonz Exp $
 #
 # @PKGNAME@ script to control ofmipd (SMTP submission service).
 #
@@ -22,7 +22,7 @@ name="qmailofmipd"
 : ${qmailofmipd_ofmipdcmd:="@PREFIX@/bin/ofmipd"}
 : ${qmailofmipd_postofmipd:=""}
 : ${qmailofmipd_log:="YES"}
-: ${qmailofmipd_logcmd:="logger -t nb${name} -p mail.info"}
+: ${qmailofmipd_logcmd:="logger -t ${procname} -p mail.info"}
 : ${qmailofmipd_nologcmd:="@PREFIX@/bin/multilog -*"}
 
 if [ -f /etc/rc.subr ]; then
@@ -34,7 +34,7 @@ required_files="@PKG_SYSCONFDIR@/control
 required_files="${required_files} @PKG_SYSCONFDIR@/tcp.ofmip.cdb"
 required_files="${required_files} @PKG_SYSCONFDIR@/control/rcpthosts"
 command="${qmailofmipd_tcpserver}"
-procname=${name}
+procname=nb${name}
 start_precmd="qmailofmipd_precmd"
 extra_commands="stat pause cont cdb reload"
 stat_cmd="qmailofmipd_stat"
@@ -50,10 +50,10 @@ qmailofmipd_precmd()
        fi
        # tcpserver(1) is akin to inetd(8), but runs one service per process.
        # We want to signal only the tcpserver process responsible for this
-       # service. Use argv0(1) to set procname to "qmailofmipd".
+       # service. Use argv0(1) to set procname to "nbqmailofmipd".
        command="@PREFIX@/bin/pgrphack @SETENV@ - ${qmailofmipd_postenv}
 @PREFIX@/bin/softlimit -m ${qmailofmipd_datalimit} ${qmailofmipd_pretcpserver}
-@PREFIX@/bin/argv0 ${qmailofmipd_tcpserver} ${name}
+@PREFIX@/bin/argv0 ${qmailofmipd_tcpserver} ${procname}
 ${qmailofmipd_tcpflags} -x @PKG_SYSCONFDIR@/tcp.ofmip.cdb
 -c `@HEAD@ -1 @PKG_SYSCONFDIR@/control/concurrencyofmip`
 -u `@ID@ -u @QMAIL_DAEMON_USER@` -g `@ID@ -g @QMAIL_DAEMON_USER@`

Index: pkgsrc/mail/qmail-run/files/qmailpop3d.sh
diff -u pkgsrc/mail/qmail-run/files/qmailpop3d.sh:1.15 pkgsrc/mail/qmail-run/files/qmailpop3d.sh:1.16
--- pkgsrc/mail/qmail-run/files/qmailpop3d.sh:1.15      Fri Jun 23 15:49:03 2017
+++ pkgsrc/mail/qmail-run/files/qmailpop3d.sh   Sat Aug  5 03:03:17 2017
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: qmailpop3d.sh,v 1.15 2017/06/23 15:49:03 schmonz Exp $
+# $NetBSD: qmailpop3d.sh,v 1.16 2017/08/05 03:03:17 schmonz Exp $
 #
 # @PKGNAME@ script to control qmail-pop3d (POP3 server for Maildirs).
 #
@@ -22,7 +22,7 @@ name="qmailpop3d"
 : ${qmailpop3d_checkpassword:="@PREFIX@/bin/checkpassword"}
 : ${qmailpop3d_maildirname:="Maildir"}
 : ${qmailpop3d_log:="YES"}
-: ${qmailpop3d_logcmd:="logger -t nb${name} -p mail.info"}
+: ${qmailpop3d_logcmd:="logger -t ${procname} -p mail.info"}
 : ${qmailpop3d_nologcmd:="@PREFIX@/bin/multilog -*"}
 
 if [ -f /etc/rc.subr ]; then
@@ -34,7 +34,7 @@ required_files="@PKG_SYSCONFDIR@/control
 required_files="${required_files} @PKG_SYSCONFDIR@/control/concurrencypop3"
 required_files="${required_files} @PKG_SYSCONFDIR@/tcp.pop3.cdb"
 command="${qmailpop3d_tcpserver}"
-procname=${name}
+procname=nb${name}
 start_precmd="qmailpop3d_precmd"
 extra_commands="stat pause cont cdb reload"
 stat_cmd="qmailpop3d_stat"
@@ -50,10 +50,10 @@ qmailpop3d_precmd()
        fi
        # tcpserver(1) is akin to inetd(8), but runs one service per process.
        # We want to signal only the tcpserver process responsible for this
-       # service. Use argv0(1) to set procname to "qmailpop3d".
+       # service. Use argv0(1) to set procname to "nbqmailpop3d".
        command="@PREFIX@/bin/pgrphack @SETENV@ - ${qmailpop3d_postenv}
 @PREFIX@/bin/softlimit -m ${qmailpop3d_datalimit} ${qmailpop3d_pretcpserver}
-@PREFIX@/bin/argv0 ${qmailpop3d_tcpserver} ${name}
+@PREFIX@/bin/argv0 ${qmailpop3d_tcpserver} ${procname}
 ${qmailpop3d_tcpflags} -x @PKG_SYSCONFDIR@/tcp.pop3.cdb
 -c `@HEAD@ -1 @PKG_SYSCONFDIR@/control/concurrencypop3`
 ${qmailpop3d_tcphost} ${qmailpop3d_tcpport} @PREFIX@/bin/qmail-popup
Index: pkgsrc/mail/qmail-run/files/qmailsmtpd.sh
diff -u pkgsrc/mail/qmail-run/files/qmailsmtpd.sh:1.15 pkgsrc/mail/qmail-run/files/qmailsmtpd.sh:1.16
--- pkgsrc/mail/qmail-run/files/qmailsmtpd.sh:1.15      Fri Jun 23 15:49:03 2017
+++ pkgsrc/mail/qmail-run/files/qmailsmtpd.sh   Sat Aug  5 03:03:17 2017
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: qmailsmtpd.sh,v 1.15 2017/06/23 15:49:03 schmonz Exp $
+# $NetBSD: qmailsmtpd.sh,v 1.16 2017/08/05 03:03:17 schmonz Exp $
 #
 # @PKGNAME@ script to control qmail-smtpd (SMTP service).
 #
@@ -22,7 +22,7 @@ name="qmailsmtpd"
 : ${qmailsmtpd_smtpdcmd:="@PREFIX@/bin/qmail-smtpd"}
 : ${qmailsmtpd_postsmtpd:=""}
 : ${qmailsmtpd_log:="YES"}
-: ${qmailsmtpd_logcmd:="logger -t nb${name} -p mail.info"}
+: ${qmailsmtpd_logcmd:="logger -t ${procname} -p mail.info"}
 : ${qmailsmtpd_nologcmd:="@PREFIX@/bin/multilog -*"}
 
 if [ -f /etc/rc.subr ]; then
@@ -34,7 +34,7 @@ required_files="@PKG_SYSCONFDIR@/control
 required_files="${required_files} @PKG_SYSCONFDIR@/tcp.smtp.cdb"
 required_files="${required_files} @PKG_SYSCONFDIR@/control/rcpthosts"
 command="${qmailsmtpd_tcpserver}"
-procname=${name}
+procname=nb${name}
 start_precmd="qmailsmtpd_precmd"
 extra_commands="stat pause cont cdb reload"
 stat_cmd="qmailsmtpd_stat"
@@ -50,10 +50,10 @@ qmailsmtpd_precmd()
        fi
        # tcpserver(1) is akin to inetd(8), but runs one service per process.
        # We want to signal only the tcpserver process responsible for this
-       # service. Use argv0(1) to set procname to "qmailsmtpd".
+       # service. Use argv0(1) to set procname to "nbqmailsmtpd".
        command="@PREFIX@/bin/pgrphack @SETENV@ - ${qmailsmtpd_postenv}
 @PREFIX@/bin/softlimit -m ${qmailsmtpd_datalimit} ${qmailsmtpd_pretcpserver}
-@PREFIX@/bin/argv0 ${qmailsmtpd_tcpserver} ${name}
+@PREFIX@/bin/argv0 ${qmailsmtpd_tcpserver} ${procname}
 ${qmailsmtpd_tcpflags} -x @PKG_SYSCONFDIR@/tcp.smtp.cdb
 -c `@HEAD@ -1 @PKG_SYSCONFDIR@/control/concurrencyincoming`
 -u `@ID@ -u @QMAIL_DAEMON_USER@` -g `@ID@ -g @QMAIL_DAEMON_USER@`

Index: pkgsrc/mail/qmail-run/files/qmailqread.sh
diff -u pkgsrc/mail/qmail-run/files/qmailqread.sh:1.12 pkgsrc/mail/qmail-run/files/qmailqread.sh:1.13
--- pkgsrc/mail/qmail-run/files/qmailqread.sh:1.12      Sun Jul 30 03:05:59 2017
+++ pkgsrc/mail/qmail-run/files/qmailqread.sh   Sat Aug  5 03:03:17 2017
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: qmailqread.sh,v 1.12 2017/07/30 03:05:59 schmonz Exp $
+# $NetBSD: qmailqread.sh,v 1.13 2017/08/05 03:03:17 schmonz Exp $
 #
 # @PKGNAME@ script to control a service providing local non-root
 # users access to see the queue. Adapted from a script by Steinar Haug.
@@ -18,7 +18,7 @@ name="qmailqread"
 : ${qmailqread_tcpport:="20025"}
 : ${qmailqread_tcpserver:="@PREFIX@/bin/tcpserver"}
 : ${qmailqread_log:="YES"}
-: ${qmailqread_logcmd:="logger -t nb${name} -p mail.info"}
+: ${qmailqread_logcmd:="logger -t ${procname} -p mail.info"}
 : ${qmailqread_nologcmd:="@PREFIX@/bin/multilog -*"}
 
 if [ -f /etc/rc.subr ]; then
@@ -27,7 +27,7 @@ fi
 
 rcvar=${name}
 command="${qmailqread_tcpserver}"
-procname=${name}
+procname=nb${name}
 start_precmd="qmailqread_precmd"
 extra_commands="stat pause cont"
 stat_cmd="qmailqread_stat"
@@ -41,9 +41,9 @@ qmailqread_precmd()
        fi
        # tcpserver(1) is akin to inetd(8), but runs one service per process.
        # We want to signal only the tcpserver process responsible for this
-       # service. Use argv0(1) to set procname to "qmailqread".
+       # service. Use argv0(1) to set procname to "nbqmailqread".
        command="@PREFIX@/bin/pgrphack @SETENV@ - ${qmailqread_postenv}
-@PREFIX@/bin/argv0 ${qmailqread_tcpserver} ${name}
+@PREFIX@/bin/argv0 ${qmailqread_tcpserver} ${procname}
 ${qmailqread_tcpflags}
 -u `@ID@ -u @QMAIL_SEND_USER@` -g `@ID@ -g @QMAIL_SEND_USER@`
 ${qmailqread_tcphost} ${qmailqread_tcpport}

Index: pkgsrc/mail/qmail-run/files/qmailsend.sh
diff -u pkgsrc/mail/qmail-run/files/qmailsend.sh:1.11 pkgsrc/mail/qmail-run/files/qmailsend.sh:1.12
--- pkgsrc/mail/qmail-run/files/qmailsend.sh:1.11       Fri Aug  4 06:35:28 2017
+++ pkgsrc/mail/qmail-run/files/qmailsend.sh    Sat Aug  5 03:03:17 2017
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: qmailsend.sh,v 1.11 2017/08/04 06:35:28 schmonz Exp $
+# $NetBSD: qmailsend.sh,v 1.12 2017/08/05 03:03:17 schmonz Exp $
 #
 # @PKGNAME@ script to control qmail-send (local and outgoing mail).
 #
@@ -42,11 +42,11 @@ hup_cmd="qmailsend_hup"
 
 qmailsend_prestart()
 {
-       # qmail-start(8) starts the various qmail processes, then exits.
-       # qmail-send(8) is the process we want to signal later.
        if [ -f /etc/rc.subr ] && ! checkyesno qmailsend_log; then
                qmailsend_logcmd=${qmailsend_nologcmd}
        fi
+       # qmail-start(8) starts the various qmail processes, then execs
+       # qmail-send(8). That's the process we want to signal later.
        command="@PREFIX@/bin/pgrphack @SETENV@ - ${qmailsend_postenv}
 qmail-start '$qmailsend_defaultdelivery'
 ${qmailsend_logcmd}"