And, having had a chance to sleep on it, some thoughts:
1. our basic unit of addition/deletion/transfer is the binary package,
and there's no way we can walk that back. PKGSRC_KEEP_BIN_PKGS will
therefor stay as it is
2. not sure how many people are using pkgsrc read-only, but it's a
useful thing and keeps us honest, so we should be supporting it
3. if you want to bootstrap, you'll want the binary packages that are
made from it. So PACKAGES should be set before bootstrapping.
Interesting to note the "make binary kits" arguments to bootstrap.
4. I think it's a bug that PACKAGES can't be set as an argument when
calling bootstrap, so diffs attached which do this
5. tested on NetBSD only (all I have ready access to right now), and
not tested with a read-only pkgsrc. However, it DTRT when
bootstrapping with defaults and when explicitly setting via --packages
on the command line (including creating the ${PACKAGES} dir itself)
I'd prefer to wait until after 2016Q3 is branched before applying
these, as it is likely to cause infrastructure packages to be rebuilt
if applied now - easier to wait until after the branch, and then pull
up to branch when tested by everyone.
Regards,
Alistair
On 19 September 2016 at 21:29, Alistair Crooks <agc%pkgsrc.org@localhost> wrote:
> I'll look into it
>
> On 19 September 2016 at 15:40, Jonathan Perkin <jperkin%joyent.com@localhost> wrote:
>> * On 2016-09-18 at 23:17 BST, Alistair G. Crooks wrote:
>>
>>> Module Name: pkgsrc
>>> Committed By: agc
>>> Date: Sun Sep 18 22:17:55 UTC 2016
>>>
>>> Modified Files:
>>> pkgsrc/doc: CHANGES-2016
>>> pkgsrc/mk/defaults: mk.conf
>>>
>>> Log Message:
>>> Change default setting of PKGSRC_KEEP_BIN_PKGS to "yes". During the build phase,
>>> binary packages will be preserved under the ${PACKAGES} directory by default.
>>
>> Turns out this breaks bootstrapping from read-only source. Tonight's
>> upstream-trunk64 bulk build failed due to:
>>
>> => Creating binary package /workspace/pkgsrc-upstream-trunk64/packages/All/bootstrap-mk-files-20160908.tgz
>> mkdir: "/workspace/pkgsrc-upstream-trunk64/packages/All": Read-only file system
>>
>> so a user bootstrapping from read-only source (maybe I'm in a small
>> minority doing this) will have to set either PACKAGES or
>> PKGSRC_KEEP_BIN_PKGS in the ./bootstrap environment.
>>
>> It'd be nice to have a cleaner fix for this.
>>
>> --
>> Jonathan Perkin - Joyent, Inc. - www.joyent.com
>>
Attachment:
bootstrap-20160920.diff
Description: Binary data