CVS commit: pkgsrc/devel/snappy

["Matthew Sporleder" <mspo%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   mspo
Date:           Sat Nov 16 19:31:30 UTC 2013

Modified Files:
        pkgsrc/devel/snappy: Makefile distinfo

Log Message:
Update to 1.1.1

(benchmarks clipped from release notes)

------------------------------------------------------------------------
r80 | snappy.mirrorbot%gmail.com@localhost | 2013-08-13 14:55:00 +0200 (Tue, 13 
Aug 2013) | 6 lines

Add autoconf tests for size_t and ssize_t. Sort-of resolves public issue 79;
it would solve the problem if MSVC typically used autoconf. However, it gives
a natural place (config.h) to put the typedef even for MSVC.

R=jsbell

------------------------------------------------------------------------
r79 | snappy.mirrorbot%gmail.com@localhost | 2013-07-29 13:06:44 +0200 (Mon, 29 
Jul 2013) | 14 lines

When we compare the number of bytes produced with the offset for a
backreference, make the signedness of the bytes produced clear,
by sticking it into a size_t. This avoids a signed/unsigned compare
warning from MSVC (public issue 71), and also is slightly clearer.

Since the line is now so long the explanatory comment about the -1u
trick has to go somewhere else anyway, I used the opportunity to
explain it in slightly more detail.

This is a purely stylistic change; the emitted assembler from GCC
is identical.

R=jeff

------------------------------------------------------------------------
r78 | snappy.mirrorbot%gmail.com@localhost | 2013-06-30 21:24:03 +0200 (Sun, 30 
Jun 2013) | 111 lines

In the fast path for decompressing literals, instead of checking
whether there's 16 bytes free and then checking right afterwards
(when having subtracted the literal size) that there are now
5 bytes free, just check once for 21 bytes. This skips a compare
and a branch; although it is easily predictable, it is still
a few cycles on a fast path that we would like to get rid of.

Benchmarking this yields very confusing results. On open-source
GCC 4.8.1 on Haswell, we get exactly the expected results; the
benchmarks where we hit the fast path for literals (in particular
the two HTML benchmarks and the protobuf benchmark) give very nice
speedups, and the others are not really affected.

However, benchmarks with Google's GCC branch on other hardware
is much less clear. It seems that we have a weak loss in some cases
(and the win for the typical win cases are not nearly as clear),
but that it depends on microarchitecture and plain luck in how we run
the benchmark. Looking at the generated assembler, it seems that
the removal of the if causes other large-scale changes in how the
function is laid out, which makes it likely that this is just bad luck.

Thus, we should keep this change, even though its exact current impact is
unclear; it's a sensible change per se, and dropping it on the basis of
microoptimization for a given compiler (or even branch of a compiler)
would seem like a bad strategy in the long run.

------------------------------------------------------------------------
r77 | snappy.mirrorbot%gmail.com@localhost | 2013-06-14 23:42:26 +0200 (Fri, 14 
Jun 2013) | 92 lines

Make the two IncrementalCopy* functions take in an ssize_t instead of a len,
in order to avoid having to do 32-to-64-bit signed conversions on a hot path
during decompression. (Also fixes some MSVC warnings, mentioned in public
issue 75, but more of those remain.) They cannot be size_t because we expect
them to go negative and test for that.

This saves a few movzwl instructions, yielding ~2% speedup in decompression.

------------------------------------------------------------------------
r76 | snappy.mirrorbot%gmail.com@localhost | 2013-06-13 18:19:52 +0200 (Thu, 13 
Jun 2013) | 9 lines

Add support for uncompressing to iovecs (scatter I/O).
Windows does not have struct iovec defined anywhere,
so we define our own version that's equal to what UNIX
typically has.

The bulk of this patch was contributed by Mohit Aron.

R=jeff

------------------------------------------------------------------------
r75 | snappy.mirrorbot%gmail.com@localhost | 2013-06-12 21:51:15 +0200 (Wed, 12 
Jun 2013) | 4 lines

Some code reorganization needed for an internal change.

R=fikes

------------------------------------------------------------------------
r74 | snappy.mirrorbot%gmail.com@localhost | 2013-04-09 17:33:30 +0200 (Tue, 09 
Apr 2013) | 4 lines

Supports truncated test data in zippy benchmark.

R=sesse

------------------------------------------------------------------------
r73 | snappy.mirrorbot%gmail.com@localhost | 2013-02-05 15:36:15 +0100 (Tue, 05 
Feb 2013) | 4 lines

Release Snappy 1.1.0.

R=sanjay

------------------------------------------------------------------------
r72 | snappy.mirrorbot%gmail.com@localhost | 2013-02-05 15:30:05 +0100 (Tue, 05 
Feb 2013) | 9 lines

Make ./snappy_unittest pass without "srcdir" being defined.

Previously, snappy_unittests would read from an absolute path /testdata/..;
convert it to use a relative path instead.

Patch from Marc-Antonie Ruel.

R=maruel

------------------------------------------------------------------------
r71 | snappy.mirrorbot%gmail.com@localhost | 2013-01-18 13:16:36 +0100 (Fri, 18 
Jan 2013) | 287 lines

Increase the Zippy block size from 32 kB to 64 kB, winning ~3% density
while being effectively performance neutral.

The longer story about density is that we win 3-6% density on the benchmarks
where this has any effect at all; many of the benchmarks (cp, c, lsp, man)
are smaller than 32 kB and thus will have no effect. Binary data also seems
to win little or nothing; of course, the already-compressed data wins nothing.
The protobuf benchmark wins as much as ~18% depending on architecture,
but I wouldn't be too sure that this is representative of protobuf data in
general.

As of performance, we lose a tiny amount since we get more tags (e.g., a long
literal might be broken up into literal-copy-literal), but we win it back with
less clearing of the hash table, and more opportunities to skip incompressible
data (e.g. in the jpg benchmark). Decompression seems to get ever so slightly
slower, again due to more tags. The total net change is about as close to zero
as we can get, so the end effect seems to be simply more density and no
real performance change.

The comment about not changing kBlockSize, scary as it is, is not really
relevant, since we're never going to have a block-level decompressor without
explicitly marked blocks. Replace it with something more appropriate.

This affects the framing format, but it's okay to change it since it basically
has no users yet.

------------------------------------------------------------------------
r70 | snappy.mirrorbot%gmail.com@localhost | 2013-01-06 20:21:26 +0100 (Sun, 06 
Jan 2013) | 6 lines

Adjust the Snappy open-source distribution for the changes in Google's
internal file API.

R=sanjay

------------------------------------------------------------------------
r69 | snappy.mirrorbot%gmail.com@localhost | 2013-01-04 12:54:20 +0100 (Fri, 04 
Jan 2013) | 15 lines

Change a few ORs to additions where they don't matter. This helps the compiler
use the LEA instruction more efficiently, since e.g. a + (b << 2) can be encoded
as one instruction. Even more importantly, it can constant-fold the
COPY_* enums together with the shifted negative constants, which also saves
some instructions. (We don't need it for LITERAL, since it happens to be 0.)

I am unsure why the compiler couldn't do this itself, but the theory is that
it cannot prove that len-1 and len-4 cannot underflow/wrap, and thus can't
do the optimization safely.

The gains are small but measurable; 0.5-1.0% over the BM_Z* benchmarks
(measured on Westmere, Sandy Bridge and Istanbul).

R=sanjay

------------------------------------------------------------------------
r68 | snappy.mirrorbot%gmail.com@localhost | 2012-10-08 13:37:16 +0200 (Mon, 08 
Oct 2012) | 5 lines

Stop giving -Werror to automake, due to an incompatibility between current
versions of libtool and automake on non-GNU platforms (e.g. Mac OS X).

R=sanjay

------------------------------------------------------------------------
r67 | snappy.mirrorbot%gmail.com@localhost | 2012-08-17 15:54:47 +0200 (Fri, 17 
Aug 2012) | 5 lines

Fix public issue 66: Document GetUncompressedLength better, in particular that
it leaves the source in a state that's not appropriate for RawUncompress.

R=sanjay

------------------------------------------------------------------------
r66 | snappy.mirrorbot%gmail.com@localhost | 2012-07-31 13:44:44 +0200 (Tue, 31 
Jul 2012) | 5 lines

Fix public issue 64: Check for <sys/time.h> at configure time,
since MSVC seemingly does not have it.

R=sanjay

------------------------------------------------------------------------
r65 | snappy.mirrorbot%gmail.com@localhost | 2012-07-04 11:34:48 +0200 (Wed, 04 
Jul 2012) | 10 lines

Handle the case where gettimeofday() goes backwards or returns the same value
twice; it could cause division by zero in the unit test framework.
(We already had one fix for this in place, but it was incomplete.)

This could in theory happen on any system, since there are few guarantees
about gettimeofday(), but seems to only happen in practice on GNU/Hurd, where
gettimeofday() is cached and only updated ever so often.

R=sanjay

------------------------------------------------------------------------
r64 | snappy.mirrorbot%gmail.com@localhost | 2012-07-04 11:28:33 +0200 (Wed, 04 
Jul 2012) | 6 lines

Mark ARMv4 as not supporting unaligned accesses (not just ARMv5 and ARMv6);
apparently Debian still targets these by default, giving us segfaults on
armel.

R=sanjay

------------------------------------------------------------------------
r63 | snappy.mirrorbot%gmail.com@localhost | 2012-05-22 11:46:05 +0200 (Tue, 22 
May 2012) | 5 lines

Fix public bug #62: Remove an extraneous comma at the end of an enum list,
causing compile errors when embedded in Mozilla on OpenBSD.

R=sanjay

------------------------------------------------------------------------
r62 | snappy.mirrorbot%gmail.com@localhost | 2012-05-22 11:32:50 +0200 (Tue, 22 
May 2012) | 8 lines

Snappy library no longer depends on iostream.

Achieved by moving logging macro definitions to a test-only
header file, and by changing non-test code to use assert,
fprintf, and abort instead of LOG/CHECK macros.

R=sesse


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 pkgsrc/devel/snappy/Makefile
cvs rdiff -u -r1.2 -r1.3 pkgsrc/devel/snappy/distinfo

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.