Re: CVS commit: pkgsrc/mk

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Fri, Aug 16, 2013 at 12:11:17PM +0000, Jonathan Perkin wrote:
> Module Name:  pkgsrc
> Committed By: jperkin
> Date:         Fri Aug 16 12:11:17 UTC 2013
> 
> Modified Files:
>       pkgsrc/mk: krb5.buildlink3.mk
>       pkgsrc/mk/platform: Darwin.mk
> 
> Log Message:
> Move platform-specific settings to the platform file.

Thanks for doing this, it's a good move.

One issue it does bring up is that the individual platform files
should be uniform in all of the fields listed in them.  So even if
something is not ever going to be worthwhile or needed on a platform,
it's still in every platform/*.mk files.  This is so that individual
platform ${OPSYS}.mk files can be used as templates for new values of
${OPSYS} and everything works just fine.  If we don't have uniformity
then this fails even more quickly than ...  well, I was going to be
catty about the setting up of a pbulk instance, but I managed to stop
myself just in time.

Best,
Alistair