Re: CVS commit: pkgsrc/audio/flac

[Thomas Klausner <wiz%netbsd.org@localhost>]

On Fri, Jun 14, 2013 at 10:28:25PM +0000, David Holland wrote:
> On Wed, Jun 12, 2013 at 08:31:51PM +0000, Thomas Klausner wrote:
>  > Modified Files:
>  >    pkgsrc/audio/flac: Makefile PLIST distinfo
>  > Removed Files:
>  >    pkgsrc/audio/flac/patches: patch-ad patch-ag patch-ah patch-ay patch-az
>  > 
>  > Log Message:
>  > Update to 1.3.0:
> 
> I think this broke multimedia/vlc and multimedia/vlc2, which are now
> failing with: 'stream_decoder.h' file not found.

It did.

The change is:
< Cflags: -I${includedir}/FLAC++
> Cflags: -I${includedir}

in the pkgconfig file. This was done on purpose in 2008.
https://git.xiph.org/?p=flac.git;a=commitdiff;h=7ae181f27c16e7eca45840ec9171b938b9f86fbc

We could revert this for pkgsrc, or go along with upstream and fix the
packages that don't prepend "FLAC" or "FLAC++" respectively when
including the files.

How many other packages failed for this reason? (None in my limited
bulk build except for vlc2, where I didn't notice due to newlocale()).
 Thomas