Re: CVS commit: pkgsrc/sysutils/xentools42

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Tue, May 28, 2013 at 10:07:22AM +0200, Manuel Bouyer wrote:
> On Mon, May 27, 2013 at 10:26:27PM +0000, Patrick Welche wrote:
> > Module Name:        pkgsrc
> > Committed By:       prlw1
> > Date:               Mon May 27 22:26:27 UTC 2013
> > 
> > Modified Files:
> >     pkgsrc/sysutils/xentools42: distinfo
> > Added Files:
> >     pkgsrc/sysutils/xentools42/patches:
> >         patch-.._.._ipxe_src_drivers_net_ath5k_ath5k_qcu.c
> >         patch-.._.._ipxe_src_drivers_net_ns83820.c
> >         patch-.._.._ipxe_src_drivers_net_tulip.c
> > 
> > Log Message:
> > Build fixes
> 
> Hello,
> at last 2 of theses are wrong: you replaced a ++tp->cur_rx with
> tp->cur_rx + 1, so tp->cur_rx isn't incremented any more.

But the line sets tp->cur_rx!

-    tp->cur_rx = (++tp->cur_rx) % RX_RING_SIZE;
+    tp->cur_rx = (tp->cur_rx + 1) % RX_RING_SIZE;

or?

Cheers,

Patrick