Re: CVS commit: pkgsrc/textproc/rarian

[Jonathan Perkin <jperkin%pkgsrc.org@localhost>]

* On 2013-02-24 at 05:19 GMT, Richard PALO wrote:

> Le 23/02/13 23:17, Jonathan Perkin a écrit :
>
> >Module Name: pkgsrc
> >Committed By:        jperkin
> >Date:                Sat Feb 23 22:17:02 UTC 2013
> >
> >Modified Files:
> >     pkgsrc/textproc/rarian: Makefile distinfo
> >Added Files:
> >     pkgsrc/textproc/rarian/patches: patch-librarian_Makefile.in
> >
> >Log Message:
> >Don't use -export-symbols-regex, it breaks non-GNU linkers and results in the
> >wrong SONAME being set, in this case to '../librarian/.libs/librarian.so'.
> >
> >Fixes a number of packages and PR#37842.
> >
> >Bump PKGREVISION, binary package needs to be updated.
>
> I believe this patch is incorrect.  The problem is related to
> pkg/47359 (pkgsrc/devel/libtool problems with solaris, g++ and solaris ld)
> and is fixed upstream, as well as with my proposed patch to libtool.

I know about that PR, but I am not confident of applying that until it has
been fully tested.  Also it's not true to say that it's been fixed
upstream, the upstream bug is still 'open' and has not yet integrated the
patch.

I would want to see the patch fully integrated into libtool and a full
fresh bulk build done on SunOS before applying it to pkgsrc.  Changing
libtool can have unintended consequences, and until then the patch I
committed is fine.

This isn't to say your patch is incorrect, but that we need to be careful
about applying it.

-- 
Jonathan Perkin       www.perkin.org.uk
github.com/jperkin  twitter.com/jperkin