pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: pkgsrc/x11

Module Name:    pkgsrc
Committed By:   is
Date:           Mon Oct 15 15:29:11 UTC 2012

Modified Files:
        pkgsrc/x11/xlockmore: Makefile distinfo
        pkgsrc/x11/xlockmore-lite: Makefile
Added Files:
        pkgsrc/x11/xlockmore/patches: patch-modes_dclock.c

Log Message:
xlock -mode dclock would segfault on OSes with sizeof(time_t)>sizeof(long);
this includes NetBSD-6 on 32bit systems.

As a result, xlock -mode random (the default) would eventually unlock
the screen, without the user being aware of this (as she/he's can be
presumed to have left the monitor).

The reason was that some variables in dclock.c were declared long, but
contain essentially time_t values. In on case, a pointer to such a
variable was casted to (struct time_t *) and passed to localtime(),
and the resulting pointer is not checked for error before being used.

The variables have been changed to time_t and the typecast has been

To generate a diff of this commit:
cvs rdiff -u -r1.99 -r1.100 pkgsrc/x11/xlockmore/Makefile
cvs rdiff -u -r1.48 -r1.49 pkgsrc/x11/xlockmore/distinfo
cvs rdiff -u -r1.15 -r1.16 pkgsrc/x11/xlockmore-lite/Makefile
cvs rdiff -u -r0 -r1.1 pkgsrc/x11/xlockmore/patches/patch-modes_dclock.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index