pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/cross/mingw-binutils

On 10/9/2012 16:29, Aleksej Saushev wrote:
"John Marino"<>  writes:

Module Name:    pkgsrc
Committed By:   marino
Date:           Tue Oct  9 07:48:21 UTC 2012

Modified Files:
        pkgsrc/cross/mingw-binutils: Makefile

Log Message:
cross/mingw-binutils: Fix build on gcc4.7

mingw-binutils is built with -Werror which fails on the gcc4.6+ warning
"unused but set variable".  Disable that warning to fix gcc4.7 build.

I suggest that you stop suppressing warnings just to make it build with
your compiler. If you know what the problem is, fix the problem.

It's not "my" compiler, it's gcc 4.6+ (see caveats, bullet 6)

1) It's not a problem.
2) I'm not going to add countless patches to source inside tarball for something that the compiler will optimize out anyway. That would cause a real headache for the next guy.
3) It didn't cause any problems undetected
4) It's the package's fault for compiling with -Werror

So I'm going to ignore that suggestion.  It's a bad one.

Home | Main Index | Thread Index | Old Index