pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/lang/racket-textual

On 9/24/2012 13:18, Aleksej Saushev wrote:
Module Name:    pkgsrc
Committed By:   asau
Date:           Mon Sep 24 11:18:38 UTC 2012

Modified Files:
        pkgsrc/lang/racket-textual: Makefile

Log Message:
Revert changes that make no sense.

To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 pkgsrc/lang/racket-textual/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Translation: Alexsej just changed all the "{}" back to "()" for no benefit, and to apparently to intentionally cause pkglint to generate warnings for the reason I can only speculate that he thinks pkglint should not classify "()" as an error.

This revert had no justification and it makes the pkgsrc Makefile worse (same story with lang/racket). This is irresponsible. For a lesser extent, OBATA Akio pointed me to commit guidelines that said one should avoid reverting commits of other developers and that was violated as well.

Apparently there's no point on using pkglint, at least on packages that asau has interest in.


Home | Main Index | Thread Index | Old Index